Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_default_substitutions to the macro and cli #936

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

tadeohepperle
Copy link
Contributor

fixes #927

Similar to no_default_derives there is now a no_default_substitutions option for the macro and cli on how to perform type substitutions in the codegen.

Added a test to check that it really works.

@tadeohepperle tadeohepperle requested a review from a team as a code owner April 27, 2023 08:14
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; looks great!

Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

@jsdw jsdw merged commit 40339b3 into master Apr 27, 2023
@jsdw jsdw deleted the tadeo-hepperle-add-no-default-substitutions branch April 27, 2023 14:59
@jsdw jsdw mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add no_default_substitutions to the macro/CLI tool
3 participants