Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Upgrade to 0.9.42 #240

Closed
7 tasks done
valentinfernandez1 opened this issue Jun 20, 2023 · 3 comments
Closed
7 tasks done

Upgrade to 0.9.42 #240

valentinfernandez1 opened this issue Jun 20, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@valentinfernandez1
Copy link
Contributor

valentinfernandez1 commented Jun 20, 2023

Upgrade Trappist's runtime from v0.9.40 to v0.9.42.

@valentinfernandez1 valentinfernandez1 added the enhancement New feature or request label Jun 20, 2023
@valentinfernandez1 valentinfernandez1 self-assigned this Jun 22, 2023
@valentinfernandez1
Copy link
Contributor Author

valentinfernandez1 commented Jun 23, 2023

@stiiifff stiiifff added this to the Trappist M2 / XCM v3 milestone Jun 27, 2023
@valentinfernandez1
Copy link
Contributor Author

@valentinfernandez1 valentinfernandez1 removed their assignment Jul 5, 2023
@vstam1
Copy link

vstam1 commented Aug 2, 2023

Looking over the XCM config I have a few points:

  • Line 62: Can't we remove Ancestry? Its never used.

  • Line 136: Could use the ConvertedConcreteId instead of ConvertedRegisteredAssetId. I can understand that the name makes more sense then ConvertedConcreteId in this case but could also create seperate type ConvertedRegisteredAssetId = ConvertedContreteId<...> to prevent code duplication. I think Gavin did change the trait bounds in 0.9.43 or still just master from Convert -> MaybeEquivalence but think that the 0.9.42 still has the old trait bounds.
    Still just a suggestion, can keep it as is.

  • Line 201: Might be able to use RockmineLocation.

  • Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.

  • General: Might be good to change from Rockmine to RococoAssetHub

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants