You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 21, 2024. It is now read-only.
@vstam1 shared the following inputs for the Trappist XCM configuration:
Line 62: Can't we remove Ancestry? Its never used.
Line 136: Could use the ConvertedConcreteId instead of ConvertedRegisteredAssetId. I can understand that the name makes more sense then ConvertedConcreteId in this case but could also create seperate type ConvertedRegisteredAssetId = ConvertedContreteId<...> to prevent code duplication. I think Gavin did change the trait bounds in 0.9.43 or still just master from Convert -> MaybeEquivalence but think that the 0.9.42 still has the old trait bounds.
Still just a suggestion, can keep it as is.
Line 201: Might be able to use RockmineLocation.
Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.
General: Might be good to change from Rockmine to RococoAssetHub
Just for tracking as I don't fully understand yet if it's on us but currently WithComputedOrigin on Barrier blocks incoming reserve asset transfer of HOP from Asset Hub.
However, reserve asset transfer of ROC from Asset Hub into Trappist, works.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@vstam1 shared the following inputs for the Trappist XCM configuration:
Line 62: Can't we remove Ancestry? Its never used.
Line 136: Could use the ConvertedConcreteId instead of ConvertedRegisteredAssetId. I can understand that the name makes more sense then ConvertedConcreteId in this case but could also create seperate type ConvertedRegisteredAssetId = ConvertedContreteId<...> to prevent code duplication. I think Gavin did change the trait bounds in 0.9.43 or still just master from Convert -> MaybeEquivalence but think that the 0.9.42 still has the old trait bounds.
Still just a suggestion, can keep it as is.
Line 201: Might be able to use RockmineLocation.
Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.
General: Might be good to change from Rockmine to RococoAssetHub
#240 (comment)
The text was updated successfully, but these errors were encountered: