Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

XCM configuration review. #256

Open
hbulgarini opened this issue Aug 2, 2023 · 2 comments
Open

XCM configuration review. #256

hbulgarini opened this issue Aug 2, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@hbulgarini
Copy link
Contributor

hbulgarini commented Aug 2, 2023

@vstam1 shared the following inputs for the Trappist XCM configuration:

  • Line 62: Can't we remove Ancestry? Its never used.

  • Line 136: Could use the ConvertedConcreteId instead of ConvertedRegisteredAssetId. I can understand that the name makes more sense then ConvertedConcreteId in this case but could also create seperate type ConvertedRegisteredAssetId = ConvertedContreteId<...> to prevent code duplication. I think Gavin did change the trait bounds in 0.9.43 or still just master from Convert -> MaybeEquivalence but think that the 0.9.42 still has the old trait bounds.
    Still just a suggestion, can keep it as is.

  • Line 201: Might be able to use RockmineLocation.

  • Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.

  • General: Might be good to change from Rockmine to RococoAssetHub

#240 (comment)

@hbulgarini hbulgarini self-assigned this Aug 2, 2023
@hbulgarini
Copy link
Contributor Author

Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.

@vstam1 i would like to touch point on this one:

How is the recommended configuration for the SendXcmOrigin if for example we want to implement a solution like the one described bellow:

paritytech/xcm-docs#34 (comment)

@stiiifff stiiifff added this to the Trappist M2 / XCM v3 milestone Aug 18, 2023
@stiiifff stiiifff added the enhancement New feature or request label Aug 18, 2023
@metricaez
Copy link
Collaborator

Just for tracking as I don't fully understand yet if it's on us but currently WithComputedOrigin on Barrier blocks incoming reserve asset transfer of HOP from Asset Hub.

However, reserve asset transfer of ROC from Asset Hub into Trappist, works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants