Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

44 defi xcm use case no1 #78

Merged
merged 15 commits into from
Nov 13, 2022
Merged

44 defi xcm use case no1 #78

merged 15 commits into from
Nov 13, 2022

Conversation

lana-shanghai
Copy link
Contributor

Generate two different runtimes from the same repo with the features flag.

@stiiifff
Copy link
Contributor

@lana-shanghai can you investigate the CI build issue ? thx !

@lana-shanghai
Copy link
Contributor Author

@lana-shanghai can you investigate the CI build issue ? thx !

This is because the commands to build have to include the flag. The commands are in README. Quote:
cargo b -r --features with-base-runtime
cargo b -r --features with-trappist-runtime

@hbulgarini
Copy link
Contributor

hbulgarini commented Nov 10, 2022

@lana-shanghai can you investigate the CI build issue ? thx !

This is because the commands to build have to include the flag. The commands are in README. Quote: cargo b -r --features with-base-runtime cargo b -r --features with-trappist-runtime

quick question: what about if i want to build both?

should i execute cargo b -r --features with-trappist-runtime with-base-runtime ? Or we need to execute two different commands?

@lana-shanghai
Copy link
Contributor Author

lana-shanghai commented Nov 10, 2022

@lana-shanghai can you investigate the CI build issue ? thx !

This is because the commands to build have to include the flag. The commands are in README. Quote: cargo b -r --features with-base-runtime cargo b -r --features with-trappist-runtime

quick question: what about if i want to build both?

should i execute cargo b -r --features with-trappist-runtime with-base-runtime ? Or we need to execute two different commands?

They have to be built one after the other. But, because they share about 99% of the same code, the second command re-builds only 3-4 crates. So, you build the first one, put it into the ./bin folder, then build the second one (wait 2 min) and put in the same folder (they have to have different names, of course). Maybe I should add a bash script to do all that together with one command, actually.

bin/polkadot Outdated Show resolved Hide resolved
build_runtimes.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@hbulgarini hbulgarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

@hbulgarini hbulgarini self-requested a review November 10, 2022 15:19
zombienet-macos Outdated Show resolved Hide resolved
hbulgarini
hbulgarini previously approved these changes Nov 13, 2022
Copy link
Contributor

@hbulgarini hbulgarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hbulgarini hbulgarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lana-shanghai lana-shanghai merged commit f9645b6 into master Nov 13, 2022
@lana-shanghai lana-shanghai deleted the 44-defi-xcm-use-case-no1 branch November 13, 2022 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants