Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hex trace output #153

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Fix hex trace output #153

merged 2 commits into from
Feb 23, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Feb 21, 2022

The trie trace logs use one line per byte, making it unreadable.
Instead put it in one line.

There is no test for this but I tested it in the playground.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez self-assigned this Feb 21, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Feb 21, 2022

It is still not really good readable, should I change it to hex::encode(…)?

@cheme
Copy link
Contributor

cheme commented Feb 23, 2022

It is still not really good readable, should I change it to hex::encode(…)?

Sounds good, maybe more ToHex as it is already use in the crate.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@arkpar arkpar merged commit 2e1541e into master Feb 23, 2022
@arkpar arkpar deleted the oty-trace-hex branch February 23, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants