Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash: use less opionated shebang #1860

Merged
merged 2 commits into from
Aug 27, 2024
Merged

bash: use less opionated shebang #1860

merged 2 commits into from
Aug 27, 2024

Conversation

FlorianFranzen
Copy link
Contributor

Not every environment has bash installed in /bin/bash, so this uses the env entrypoint in /usr/bin instead to make the bash scripts more portable, e.g. to work on NixOS.

@FlorianFranzen FlorianFranzen mentioned this pull request Aug 27, 2024
Closed
pepoviola
pepoviola approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@FlorianFranzen
Copy link
Contributor Author

Also added a fix for another odd bug where $ECHO is not defined. Not sure how that happened and how I am the only one that has this problem.

@pepoviola pepoviola merged commit e9f0993 into paritytech:main Aug 27, 2024
19 of 22 checks passed
@FlorianFranzen FlorianFranzen deleted the shebang-fix branch September 25, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianFranzen @pepoviola