Fix kubernetes provider synchronization issues #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fn: KubeClient::createResource arg: waitReady
- We were assessing if the transfer-files-container is ready only by checking if it's state is "running". While this is necessary, it is not enough. We need to make sure that it finished initializing (downloading coreutils). We do this by looking for the "waiting for tar to finish" line in the logs - Define a reusable method for retrying actions.
- Wait for the chain to start before trying to copy the chain spec file - Use wait_log() for getChainSpecRaw()
I stumbled upon a lot of failures when downloading coreutils, after curl had been downloaded successfully from the same server. Not sure why. Might be an issue with the wget used in the container. Anyway, not using https seems to fix the issue.
pepoviola
reviewed
Mar 18, 2023
| @@ -42,7 +43,10 @@ export async function setupChainSpec( | |||
| const podName = podDef.metadata.name; | |||
| await client.spawnFromDef(podDef); | |||
|
|
|||
| debug("copy file from pod"); | |||
| debug("waiting for chain-spec"); | |||
| await client.waitLog(podName, podName, NODE_CONTAINER_WAIT_LOG); | |||
pepoviola
approved these changes
Mar 18, 2023
|
@pepoviola thank you for the review ! @wirednkod would you like to take a look on this PR ? Or could I go ahead and merge it ? |
wirednkod
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some issues that I stumbled upon while working on #796