Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

features improvement #33

Merged
merged 5 commits into from
Sep 5, 2024
Merged

features improvement #33

merged 5 commits into from
Sep 5, 2024

Conversation

valentin-vrps
Copy link
Collaborator

@valentin-vrps valentin-vrps commented Jul 5, 2024 •
edited
Loading

Motivation

Fix bugs and add new features/improvements

Changes

Test

  • Display all feedback sent by the professor above feedback form
  • Increase max sound volume
  • Remove modal before downloading video
  • Hide show feedbacks button on pre mounting step if no feedbacks
  • Title's style should be correctly applied in title card and diaporama component
  • Try to change background color and text color of title

@valentin-vrps valentin-vrps force-pushed the features_improvement branch 16 times, most recently from 52d8d62 to 3a23782 Compare July 11, 2024 15:10
@valentin-vrps valentin-vrps force-pushed the features_improvement branch from 3a23782 to fac9cb1 Compare July 12, 2024 13:42
@valentin-vrps valentin-vrps force-pushed the features_improvement branch 13 times, most recently from 78a1057 to f335c14 Compare August 13, 2024 14:15
@valentin-vrps valentin-vrps force-pushed the features_improvement branch 3 times, most recently from 45d7223 to 1e84fce Compare August 14, 2024 15:49
@DavidRobertAnsart DavidRobertAnsart merged commit 1fb149e into master Sep 5, 2024
0 of 3 checks passed
@DavidRobertAnsart DavidRobertAnsart deleted the features_improvement branch September 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidRobertAnsart DavidRobertAnsart DavidRobertAnsart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin-vrps @DavidRobertAnsart