Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry GetPlanning a given amount of time then exit in error #132

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

gabriel-farache
Copy link
Collaborator

In Move2kube, there is no feedback given to the API if an error occurs while running the plan (see konveyor/move2kube-api#159)
Hence, the workflow is waiting for ever

This PR introduces a new parameter to set the amount of time the user wants to retry to get the planning until it's considered as failed/timeout. By default the max retry is set to 10

Closes https://issues.redhat.com/browse/FLPATH-1094

Copy link
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway, if you want to have a look here there is also an option to stop after a configured amount of seconds, instead of retries

@masayag masayag merged commit 8d27f0e into main Mar 12, 2024
4 checks passed
rgolangh pushed a commit to parodos-dev/serverless-workflows-config that referenced this pull request Mar 12, 2024
masayag pushed a commit to parodos-dev/serverless-workflows-config that referenced this pull request Mar 12, 2024
masayag pushed a commit to parodos-dev/serverless-workflows-config that referenced this pull request Mar 12, 2024
@gabriel-farache gabriel-farache deleted the fix/m2k_set_getplan_max_retries branch March 13, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants