Comparison between libui-node & libui-napi #11

parro-it · 2018-05-04T17:26:26Z

I completed the initial implementation of windows, boxes and multiline entry.
I then created a new branch from 0_3_0 branch of libui-node, removed all the stuff except windows, boxes and multiline entry.
Here is a comparison of the two implementation to help decide if the N-API rewrite is worth the effort:

nbind version

binary size: 627Kb
compilation time: 39s
runtime memory consuption of example.js: 21M

N-API version

binary size 56Kb
compilation time: 7s
runtime memory consuption of example.js: 18M

Considering also that N-API greatly simplify publish of prebuilt binaries, and that it offer much control on memory management and type conversion, my opinion is that the conversion it's totally
worth the effort.

mischnic · 2018-05-04T18:06:34Z

What about compatibility?

parro-it · 2018-05-04T18:09:52Z

You mean at API level? It's pretty good

You can compare https://github.com/parro-it/libui-node/blob/0_3_0/examples/example-from-napi.js and https://github.com/parro-it/libui-napi/blob/master/example/using-classes/index.js

mischnic · 2018-05-04T18:12:01Z

Great, but what I really meant is node support for NAPI.

parro-it · 2018-05-04T18:19:18Z

It works with node >=8

parro-it · 2018-05-04T18:19:57Z

Are you concerned on getting support for older versions?

mischnic · 2018-05-04T18:22:30Z

Are you concerned on getting support for older versions?

(Most likely not worth it.)

mischnic · 2018-05-04T18:24:04Z

It works with node >=8

libui-napi/package.json

Lines 19 to 21 in ee33206

    
           "engines": { 
        
             "node": ">=10" 
        
           },

Well..

parro-it · 2018-05-04T18:26:08Z

Fixed!

parro-it · 2018-05-04T18:28:02Z

Regarding how to organize the development, I'm in doubt if it would be better to move all the stuff
I already did here to a new branch in libui-node, or otherwise keep libui-napi as a separate repo and
use libui-node only for the wrapper classes.
Any thought?

mischnic · 2018-05-04T18:29:19Z

use libui-node only for the wrapper classes.

What wrapper classes?

parro-it · 2018-05-04T18:31:14Z

These: https://github.com/parro-it/libui-napi/tree/master/js
The native part now bind libui functions one-by-one, and these classes should provide the same API as previews release.

mischnic · 2018-05-04T18:41:01Z

Any thought?

Not sure.
Everything being in one place might make development easier.

mischnic · 2018-05-04T18:41:58Z

What about linux and windows?

Windows doesn't like the _Atomic(bool) syntax.
Linux doesn't know pthread_rwlock_t.

parro-it · 2018-05-04T18:42:28Z

Everything being in one place might make development easier.

Yes, I agree.

parro-it · 2018-05-07T19:45:32Z

Windows doesn't like the _Atomic(bool) syntax.

By now, I removed the _Atomic altogether... I should think of a better solution...

Linux doesn't know pthread_rwlock_t.

Are we using it?

mischnic · 2018-05-07T19:46:54Z

Are we using it?

No, it's used in uv.h and was fixed by changing -std=c11 to -std=gnu11.

parro-it · 2018-05-07T19:49:42Z

No, it's used in uv.h and was fixed by changing -std=c11 to -std=gnu11.

Now I get the reason for that change...

parro-it · 2018-05-07T19:50:16Z

The Atomic usage could probably be replaced by some other thread synchronization function implemented by libuv

mischnic · 2018-05-07T19:50:52Z

Now I get the reason for that change...

Took quite a while to find that on the internet.

parro-it · 2018-05-07T19:54:17Z

Took quite a while to find that on the internet.

I guess, there is no much documentation or example around...

I have a collection of bookmark on some reference related to node event loop and libuv docs / example / article. How could I share them?

mischnic · 2018-05-07T19:56:05Z

a gist?

parro-it · 2018-05-07T19:59:00Z

https://gist.github.com/parro-it/842ff46a86142c30b1f94f97bb738418
The titles are not saved unfortunatly... ☹️

mischnic · 2018-05-08T18:58:34Z

Are you concerned on getting support for older versions?

N-API is now available in Node 6.14.2. If we want to, these changes would be required:

use the polyfill for async-hooks (the official creditkarma/async-hooks - mine isn't needed).
async and await aren't supported 😞 (in the download scripts).

parro-it · 2018-05-08T19:02:16Z

N-API is now available in Node 6.14.2.

Awesome! Is that a new release where they backported N-API or what?

async and await aren't supported 😞 (in the download scripts).

We can change that stuff, not a great deal...

(the official creditkarma/async-hooks - mine isn't needed)

If I remember correctly, using your we can support node 4?

parro-it · 2018-05-08T19:02:44Z

If I remember correctly, using your we can support node 4?

Ah no, because it doesn't have N-API I guess...

mischnic · 2018-05-08T19:03:40Z

Awesome! Is that a new release where they backported N-API or what?

Exactly.

If I remember correctly, using your we can support node 4?

Ah no, because it doesn't have N-API I guess...

Exactly. 😄

mischnic · 2018-05-08T19:37:45Z

Why is the library file called node_libui.node while this will be called "libui-node"?

parro-it · 2018-05-08T19:49:41Z

Why is the library file called node_libui.node while this will be called "libui-node"?

Uhm, no reason...

parro-it · 2018-05-25T10:02:52Z

After 21 days of work, the port is almost complete, so I thought to repeat the comparison with the full version of libui-node@0.2.0

nbind version
binary size: 627Kb
compilation time: 39s
runtime memory consuption of example.js: 21M

N-API version
binary size 3,0M
compilation time: 234s
runtime memory consuption of example.js: 19M

prebuilt binaries are now available for linux, windows & macOS 32bit.
Maybe we should support also for 32bit versions?

Also the structure of the repo (folders, files, tools) should be almost stable, so I think we could merge back this repo into a new branch 0_4_0 on libui-node as soon are tester branch is merged

mischnic · 2018-05-25T21:18:00Z

Maybe we should support also for 32bit versions?

Not needed for macOS. How many 32bit Windows and Linux users are there?

mischnic · 2018-05-30T07:37:21Z

So what's your plan? If this becomes libui-node 0.4.0, what changes would be in 0.3.0?

parro-it · 2018-05-30T07:49:32Z

So what's your plan? If this becomes libui-node 0.4.0, what changes would be in 0.3.0?

I thought two option here:

Just keep in 0.3 what we already started to work on (the two existing PRs). Move everything else in 0.4.0
Keep in 0.3.0 everything not already solved/implemented in libui-napi

I honestly prefer the first option, I fear the second will force us to implements some pieces two times...

mischnic · 2018-11-02T15:43:46Z

Do you want to include tables in the next libui-node (=napi) release?

parro-it · 2018-11-02T15:44:53Z

Do you want to include tables in the next libui-node (=napi) release?

Yes, that's the idea. We are not too far away anyway...

bigopon · 2018-11-28T08:42:23Z

@parro-it @mischnic From this conversation, I understand that if I want to experiment with libui node, I should start on libui napi? If so, is it in experiment ready state?

parro-it · 2018-11-28T08:45:48Z

Well, the project is almost completed, I'm finishing binding of uiTables. So yes, I guess it is in an "experiment ready state".

But what are you thinking to experiment exactly? Are you trying to write a small app?

parro-it · 2018-11-28T08:47:41Z

The version published on npm may be not up-to-date.
And be aware that the package name will change when we'll merge back in main libui-node repo

bigopon · 2018-11-28T08:57:08Z

@parro-it thanks for prompt reply.
I want to experiment integrating libui node with Aurelia version next (vNext), ideally, it should be along these lines:

// app.ts
@customElement({
  name: 'app',
  template: `<template>
    <ui-form>
      <ui-entry text.bind="firstName" />
      <ui-entry text.bind="middleName" />
      <ui-entry text.bind="lastName" />
      <ui-multiline text.bind="bio" height="50" />
    </form>
  </template>`
})
export class App {
  firstName = 'Andrea';
  middleName = '';
  lastName = 'Parodi';
  bio = '';
}

Also able to define your own custom element.

This is to verify our renderer of version next, which has worked well so far in my experiment with PIXIjs, NativeScript, and server side rendering. if you are interested, here is the repo

About the experiment, thanks for the heads up, I'll give it a go (just finished installing 0.2 though)

parro-it · 2018-11-28T09:02:59Z

Oh, nice experiment... I remember I spoke with @EisenbergEffect months ago about an Aurelia renderer, but can't recall the issue ATM...

About the experiment, thanks for the heads up, I'll give it a go (just finished installing 0.2 though)

Anyway, libui-napi will have the same public API of previuos libui-node (plus table API that we won't implement in old versions)

bigopon · 2018-11-28T09:20:48Z

Just installed, beside 2 warnings, I guess everything is good. Will update with result. Thanks.

EisenbergEffect · 2018-11-29T01:02:26Z

@parro-it It was a while ago that we talked but we're finally at a place where we can start working with what you've built. We're deep into our vNext implementation for Aurelia and we're proving out our renderer design to make sure we can render to various interesting targets besides just HTML. @bigopon is spearheading that effort and libui is next on the list :)

parro-it mentioned this issue May 5, 2018

typescript support ? parro-it/libui-node#106

Open

parro-it mentioned this issue May 8, 2018

Add support for node 6 #19

Closed

Comparison between libui-node & libui-napi #11

Comparison between libui-node & libui-napi #11

Comments

parro-it commented May 4, 2018 • edited Loading

nbind version

N-API version

mischnic commented May 4, 2018

parro-it commented May 4, 2018

mischnic commented May 4, 2018 • edited Loading

parro-it commented May 4, 2018

parro-it commented May 4, 2018

mischnic commented May 4, 2018

mischnic commented May 4, 2018

parro-it commented May 4, 2018

parro-it commented May 4, 2018 • edited Loading

mischnic commented May 4, 2018

parro-it commented May 4, 2018

mischnic commented May 4, 2018

mischnic commented May 4, 2018

parro-it commented May 4, 2018

parro-it commented May 7, 2018

mischnic commented May 7, 2018

parro-it commented May 7, 2018

parro-it commented May 7, 2018

mischnic commented May 7, 2018

parro-it commented May 7, 2018

mischnic commented May 7, 2018

parro-it commented May 7, 2018

mischnic commented May 8, 2018

parro-it commented May 8, 2018

parro-it commented May 8, 2018

mischnic commented May 8, 2018

mischnic commented May 8, 2018

parro-it commented May 8, 2018

parro-it commented May 25, 2018

mischnic commented May 25, 2018

mischnic commented May 30, 2018

parro-it commented May 30, 2018

mischnic commented Nov 2, 2018

parro-it commented Nov 2, 2018

bigopon commented Nov 28, 2018

parro-it commented Nov 28, 2018

parro-it commented Nov 28, 2018

bigopon commented Nov 28, 2018

parro-it commented Nov 28, 2018

bigopon commented Nov 28, 2018

EisenbergEffect commented Nov 29, 2018

parro-it commented May 4, 2018 •

edited

Loading

mischnic commented May 4, 2018 •

edited

Loading

parro-it commented May 4, 2018 •

edited

Loading