Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript support ? #106

Open
sandangel opened this issue May 5, 2018 · 11 comments
Open

typescript support ? #106

sandangel opened this issue May 5, 2018 · 11 comments

Comments

@sandangel
Copy link

Could you consider adding typing for typescript support?

@parro-it
Copy link
Owner

parro-it commented May 5, 2018

I don't know typescript, but I happily accept a PR if you would mind.

@sandangel
Copy link
Author

Sure, but I will have to investigate the API and architecture of this lib first. I can see the API in .js file is simple, but the API in the .cc files is pretty large. Could you please point me out the docs about the overall architecture? I think this docs will help other contributors too.

@parro-it
Copy link
Owner

parro-it commented May 5, 2018

You can start from here: https://github.com/parro-it/libui-node/blob/master/docs/readme.md
The first five links explain general concepts, while the others are for widgets.

Regarding architecture, we're experimenting with N-API: parro-it/libui-napi#11

@parro-it
Copy link
Owner

parro-it commented May 5, 2018

Oh I forgot, please base your work on branch 0_3_0. That will be the next release.

@sandangel
Copy link
Author

Thanks. I will give it a try.

@parro-it
Copy link
Owner

@sandangel any news?

@sandangel
Copy link
Author

@parro-it working on it. I think I will send a PR this weekend.

@TomasHubelbauer
Copy link

Thanks for working on this @sandangel, it will be very useful to me.

@sandangel
Copy link
Author

sandangel commented May 21, 2018

@parro-it could you help by adding some JSDocs on public API like Size, Point... as well as on FontAttribute, OpenTypeFeatures ... methods?

@sandangel
Copy link
Author

hi @parro-it I have sent a PR but since I don't know C++ much, could you please preview if the return type is correct?

@parro-it
Copy link
Owner

Thank you @sandangel, I will review it today later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants