-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript support ? #106
Comments
I don't know typescript, but I happily accept a PR if you would mind. |
Sure, but I will have to investigate the API and architecture of this lib first. I can see the API in .js file is simple, but the API in the .cc files is pretty large. Could you please point me out the docs about the overall architecture? I think this docs will help other contributors too. |
You can start from here: https://github.com/parro-it/libui-node/blob/master/docs/readme.md Regarding architecture, we're experimenting with N-API: parro-it/libui-napi#11 |
Oh I forgot, please base your work on branch 0_3_0. That will be the next release. |
Thanks. I will give it a try. |
@sandangel any news? |
@parro-it working on it. I think I will send a PR this weekend. |
Thanks for working on this @sandangel, it will be very useful to me. |
@parro-it could you help by adding some JSDocs on public API like Size, Point... as well as on FontAttribute, OpenTypeFeatures ... methods? |
hi @parro-it I have sent a PR but since I don't know C++ much, could you please preview if the return type is correct? |
Thank you @sandangel, I will review it today later... |
Could you consider adding typing for typescript support?
The text was updated successfully, but these errors were encountered: