Node 6

[mischnic]

Closes #19

• remove await/async in tools
• add to ci

[mischnic]

I also refactored functions used in both tools into a seperate file.

What would happen if CI ran with multiple node versions? Would they all get published (or multiple times)?

[parro-it]

I also refactored functions used in both tools into a seperate file.

You rock!

What would happen if CI ran with multiple node versions? Would they all get published (or multiple times)?

We can filter it:

https://github.com/mafintosh/a-napi-example/blob/c42058fdb2f3d8bc771fe5ac26a8264dd2d900eb/appveyor.yml#L32-L41

https://github.com/mafintosh/a-napi-example/blob/c42058fdb2f3d8bc771fe5ac26a8264dd2d900eb/.travis.yml#L24-L34

[mischnic]

We can filter it:

Pushed. Take a look at the compile errors with older node versions (but the compiled binary works with older verions).

I also refactored functions used in both tools into a seperate file.

While testing the download tools, I nearly rm-rf-ed my home folder while trying to delete the cache 😄 . I'll have to restore some dot files from my backup...

[parro-it]

Fun fact: while testing the download tools, I nearly rm-rf-ed my home folder while trying to delete the cache 😄 . I'll have to restore some dot files from my backup...

Beware! We should rest more 🧐
😆😆

[parro-it]

https://nodejs.org/api/n-api.html#n_api_napi_fatal_exception
https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope

We should remove that two functions... supported only from node >9

[parro-it]

https://nodejs.org/api/n-api.html#n_api_napi_fatal_exception
https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope

We should remove that two functions... supported only from node >9

I'll take care of this, but cannot tonight... will do tomorrow

[parro-it]

Removed offending functions.
Remove of callback_scope seem to have no observable effects.
But napi_fatal_exception is essential to trigger a useful uncaught exception.
By now, I replaced it with napi_fatal_error, but this . function call abort and brutally kill the process, so it is sub-optimal.
Maybe it's better to just write exception errors on stderr?

[parro-it]

More info here:
nodejs/node#15371
nodejs/node#14697

[parro-it]

Strangely enough, AppVeyor does not install node 6.14.2, it seems stick with 6.14.1

Forcing it:

[parro-it]

Finally I was able to install the correct node 6 version on AV. Merging...