Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round coverage down #257

Closed
wants to merge 1 commit into from
Closed

Conversation

tonyvanriet
Copy link

@tonyvanriet tonyvanriet commented Apr 7, 2021

The coverage percentage is rounded down instead of rounding to the
nearest tenth. This prevents a project with a large number of lines from
passing with 100.0% coverage when there are actually lines that are not
covered.

I can imagine wanting this to be a config option instead, while keeping the
current behavior as default, but I thought I'd throw out this PR to start the
discussion at least.

The coverage percentage is rounded down instead of rounding to the 
nearest tenth. This prevents a project with a large number of lines from 
passing with 100.0% coverage when there are actually lines that are not 
covered.
@bjornrud bjornrud deleted the branch parroty:master July 27, 2022 17:40
@bjornrud bjornrud deleted the master branch July 27, 2022 17:40
@tonyvanriet
Copy link
Author

taken care of in #310
thanks @albertored

@tonyvanriet tonyvanriet closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant