Make global mock experimental feature and disable it by default #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though all tests passed and the global mock was tested with an external application, it was pretty optimistic to enabled that by default. This commit changes default behavior that mocks every cassette and adds an ability to enable the experimental feature. To do so, extend your `test.exs`: ```elixir config :exvcr, [ global_mock: true ] ``` In Travis CI we run the same test for both default behaviour and global mock.
surik
changed the title
surik
changed the title
|
Also, here I'm addressing the issue with |
|
Thanks! |
tcitworld
added a commit
to framasoft/mobilizon
that referenced
this pull request
Oct 8, 2020
parroty/exvcr#160 fixes an issue with v0.12.0 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though all tests passed and the global mock was tested with an external application,
it was pretty optimistic to enabled that by default.
This commit changes default behavior that mocks every cassette and adds an ability to enable
the experimental feature. To do so, extend your
test.exs:In Travis CI we run the same test for both default behavior and global
mock.