ParseFacebookUtils.isLinked(user) returning false after executing query with 'user' key included

[SobanMahmood]

I have Parse object named 'Activity' on back end, which has a pointer to 'User' object.
In my android app, after logging in or linking through ParseFacebookUtils, if I made a parse query on 'Activity' and include key 'user' to that query for fetching users' details, then ParseFacebookUtils.isLinked(ParseUser.getCurrentUser()) starts returning false after that query. However if I kill android app and relaunch it, then ParseFacebookUtils.isLinked(ParseUser.getCurrentUser()) starts returning true again. It seems as for some reason some cached data is getting affected after making query with 'user' key included. This does not happen if query is made without including key 'user'.
This happens if at least one of the fetched 'Activities' has current logged in user set as the 'user' pointer.

[SobanMahmood]

Sdks I am using are as following:
com.facebook.android:facebook-android-sdk:4.6.0
com.parse:parsefacebookutils-v4-android:1.10.3@aar
com.parse:parse-android:1.10.3

[parse-github-bot]

Thank you for your feedback. We prioritize issues that have clear and concise repro steps. Please see our Bug Reporting Guidelines about what information should be added to this issue.

Please try the latest SDK. Our release notes have details about what issues were fixed in each release.

In addition, you might find the following resources helpful:

• Documentation: https://www.parse.com/docs
• Google Groups: https://groups.google.com/forum/#!forum/parse-developers
• Stack Overflow: http://stackoverflow.com/tags/parse.com

[wangmengyan95]

Hi @SobanMahmood, do you use the local datastore in your app?

[SobanMahmood]

Hi @wangmengyan95 , thanks for the response.
Yeah, I am using local datastore in my app.
Please let me know if any other info is required.

[wangmengyan95]

Hi @SobanMahmood, another question I want to know is whether you use the local datastore all the time? All the time means when you log in or link with Facebook and do the query, the local datastore is always enabled. I assume this is your case, but I just want to make sure, since we have some migration step when you first enable local datastore. I want to narrow down the scope. Thanks.

[SobanMahmood]

@wangmengyan95 yeah, Local datastore is always enabled in my case. In fact it is enabled at start of the application in overridden method onCreate() of extended Application class.

[wangmengyan95]

Hi @SobanMahmood, I can repo this issue. It seems a valid bug. I will try to figure out why this happen. Thanks for opening this issue! Right now I am not sure whether it is a bug of Parse or ParseFacebookUtils. If it is a bug of ParseFacebookUtils, I will create a new issue in ParseFacebookUtils and close this one.

[wangmengyan95]

I find the cause of this issue. When you login, we keep an in-memory and in-disk currentUser object. When you query a ParseUser, the server will not include the authData for security reason. For you case, if you include the user key, when we get the response and try to decode it, we will try to use the incomplete data to rebuild the user. If the user is the currentUser, we will use the new-build user which is incomplete to overwrite the in-memory currentUser. That's why the ParseFacebookUtils.isLinked(ParseUser.getCurrentUser()) will return false. However, since we do not change the in-disk currentUser, when you relaunch the app, we read the currentUser from disk and ParseFacebookUtils.isLinked(ParseUser.getCurrentUser()) return the true result.
My current solution for this is to change the third parameter here, since if the Object is a _User object, we can not guarantee it is complete. But I am not 100% sure it is safe to do this. Any thoughts? @grantland

[SobanMahmood]

Hi @wangmengyan95, thanks for the support. I hope this issue will get fixed in next release. Until then, is there any work around possible with the current version?

[wangmengyan95]

Hi @SobanMahmood, one possible solution is after you do this kind of query, you manually fetch the currentUser by calling ParseUser.getCurrentUser().fetchInBackground(); or ParseUser.getCurrentUser().fetch(); (depends on whether you want to use the async or sync version). Then the currentUser should contain the authData.

[grantland]

@wangmengyan95 we'd probably want to add authData to the checks here: https://github.com/ParsePlatform/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ParseUser.java#L506

[SobanMahmood]

Thanks @wangmengyan95 for the work around, that seems simple, I hope this will do the trick.