Avoid cleaning currentUser authData in setState #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @grantland and @hallucinogen to be potential reviewers. |
| } | ||
| // Avoid clearing authData when updating the current user's State via ParseQuery result | ||
| if (isCurrentUser() && getAuthData() != null && newState.get(KEY_AUTH_DATA) == null) { | ||
| newState = newState.newBuilder().put(KEY_AUTH_DATA, getAuthData()).build(); |
There was a problem hiding this comment.
Nit: Let's move isCurrentUser() check out a level so we don't have to do it twice
|
One nit, otherwise LGTM |
wangmengyan95
force-pushed
the
wangmengyan.fix_clear_currentUser_authData
branch
from
df0a95d to
4971873
Compare
|
@wangmengyan95 updated the pull request. |
wangmengyan95
added a commit
that referenced
this pull request
Dec 17, 2015
…entUser_authData Avoid cleaning currentUser authData in setState
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269