Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename functions that cause shadow members #1054

Merged

Conversation

oliveiradev
Copy link
Contributor

@oliveiradev oliveiradev commented Jul 31, 2020

Problem

Some extension functions cause shadow member function, it means that the member function of the extended class always have the preference when the IDE shows suggestions.

Porpuse

I renamed some extension function's name to use coroutine prefix, it solves the problem but I do not know if this name is the best option.

I'm open to suggestions

Resolve #1016

@Jawnnypoo
Copy link
Member

I think that suspend could be a better prefix. While we are making changes here, can we also change the package of all these functions to com.parse.coroutines with all these methods in the same package? (can still be in different files)

@oliveiradev
Copy link
Contributor Author

Good, I think that it makes sense

@Jawnnypoo Jawnnypoo merged commit 797786f into parse-community:master Aug 3, 2020
@Jawnnypoo
Copy link
Member

Thanks a bunch @oliveiradev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use coroutines extension function save
2 participants