Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gradle and other dependencies #1122

Closed
wants to merge 8 commits into from
Closed

Update gradle and other dependencies #1122

wants to merge 8 commits into from

Conversation

mobilekosmos
Copy link

@mobilekosmos mobilekosmos commented Oct 13, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

Related issue: #FILL_THIS_OUT

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

mobilekosmos and others added 7 commits September 29, 2021 19:43
@mobilekosmos
Updated dependencies + changes accordingly.
96e9829 
Important notes:
- minSDK set to API 28 as I prioritize security and adopting new standards over supporting old insecure platforms.
- Old module GCM removed.
- jacoco disabled as using the compiled version over jitpack leads to compilation errors which I could not fix so far.
@mobilekosmos
MindSDK lowered to 21 + gradle publications fixed + gcm module remove…
8c5b604 
…d + dependencies updated and unneeded anymore removed.
@mobilekosmos
Added maven publish configuration to more modules.
1cfec9f
@mobilekosmos
Added maven publish configuration to remaining modules.
e36c84f
@mobilekosmos
Added comment + TODO about publishing javadocs and sources.
ff609a4
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
24af9af 
# [2.0.0](mobilekosmos/Parse-SDK-Android@1.26.0...2.0.0) (2021-10-12)

### Bug Fixes

* remove GCM module ([#1091](https://github.com/mobilekosmos/Parse-SDK-Android/issues/1091)) ([aa16bcf](mobilekosmos@aa16bcf))
* upgrade Facebook SDK ([#1105](https://github.com/mobilekosmos/Parse-SDK-Android/issues/1105)) ([6f4bdb0](mobilekosmos@6f4bdb0))

### Features

* update all dependencies and modernize the source base ([#1095](https://github.com/mobilekosmos/Parse-SDK-Android/issues/1095)) ([a977d11](mobilekosmos@a977d11))

### BREAKING CHANGES

* CHANGE

Support for Google Cloud Messaging (GCM) is removed, use Firebase Cloud Messaging instead. See the [Google developer documentation](https://developers.google.com/cloud-messaging/faq) for more details and migration assistance. ([aa16bcf](aa16bcf))
@mobilekosmos
Gradle updated to v7.x + related changes + some dependencies updated.
0732e4d
@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please check all required checkboxes at the top, otherwise your pull request will be closed.

  • ⚠️ Remember that a security vulnerability must only be reported confidentially, see our Security Policy. If you are not sure whether the issue is a security vulnerability, the safest way is to treat it as such and submit it confidentially to us for evaluation.

azlekov
azlekov approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@azlekov azlekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mobilekosmos great job with this PR. I have missed some configurations regarding Jitpack and with #1095 my idea was not to update OkHttp or SDK version which you covered here - that's cool.

I left just few refactor comments.

build.gradle Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
ktx/build.gradle Show resolved Hide resolved
settings.gradle Show resolved Hide resolved
This was referenced Oct 13, 2021
Merged
Closed
@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021 •
edited
Loading

Please let know when this is ready, so we can publish a release to fix #1124.

@mobilekosmos mobilekosmos mentioned this pull request Oct 13, 2021
Closed
@mobilekosmos
Copy link
Author

Please let know when this is ready, so we can publish a release to fix #1124.

It's ready for me.

@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021 •
edited
Loading

Could you please merge master into this and resolve the conflicts? The changes in the chagelog file can all be reverted, the changelog is generated automatically now.

mtrezza
mtrezza reviewed Oct 13, 2021
View reviewed changes
facebook/build.gradle
publishing {
publications {
// Creates a Maven publication called “debug”.
debug(MavenPublication) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? It creates a maven publication "debug" but uses components "release".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name is not really relevant externally but I will double check.

@mobilekosmos
Copy link
Author

Could you please merge master into this and resolve the conflicts? The changes in the chagelog file can all be reverted, the changelog is generated automatically now.

Oh, I see there was a huge PR, waiting for an issue with it to be solved first.

@mtrezza mtrezza marked this pull request as draft October 14, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza left review comments

@azlekov azlekov azlekov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mobilekosmos @mtrezza @azlekov @semantic-release-bot