Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for uploading a ParseFile from a URI #1207

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

hej2010
Copy link
Contributor

@hej2010 hej2010 commented Feb 15, 2024

New Pull Request Checklist

Issue Description

Adds support for uploading a ParseFile from a Uri.

Closes: #1206

Approach

Followed the code from how it works using a File and byte[].

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Feb 15, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@hej2010
Copy link
Contributor Author

hej2010 commented Feb 15, 2024

I added some tests but could not test it using a content uri, only from file uris

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (f9843c5) 0.00% compared to head (1c10476) 0.00%.
Report is 2 commits behind head on master.

Files Patch % Lines
...arse/src/main/java/com/parse/ParseUriHttpBody.java 0.00% 37 Missing ⚠️
...e/src/main/java/com/parse/ParseFileController.java 0.00% 22 Missing ⚠️
.../main/java/com/parse/ParseCountingUriHttpBody.java 0.00% 20 Missing ⚠️
.../src/main/java/com/parse/ParseRESTFileCommand.java 0.00% 17 Missing ⚠️
parse/src/main/java/com/parse/ParseFileUtils.java 0.00% 8 Missing ⚠️
parse/src/main/java/com/parse/ParseFile.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1207    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         122     124     +2     
  Lines        9971   10076   +105     
  Branches     1345    1359    +14     
=======================================
- Misses       9971   10076   +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza
Copy link
Member

mtrezza commented Feb 15, 2024

Please see the failing CI

@mtrezza mtrezza changed the title Adds support for uploading a ParseFile from a Uri feat: Add support for uploading a ParseFile from a URI Feb 15, 2024
@mtrezza mtrezza requested review from azlekov and a team and removed request for azlekov February 16, 2024 23:35
Copy link
Member

@rommansabbir rommansabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mtrezza
Copy link
Member

mtrezza commented Feb 18, 2024

@rommansabbir Thanks for reviewing

@mtrezza mtrezza merged commit 83aec68 into parse-community:master Feb 18, 2024
6 of 7 checks passed
parseplatformorg pushed a commit that referenced this pull request Feb 18, 2024
# [4.3.0](4.2.1...4.3.0) (2024-02-18)

### Features

* Add support for uploading a `ParseFile` from a URI ([#1207](#1207)) ([83aec68](83aec68))
@parseplatformorg
Copy link

🎉 This change has been released in version 4.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for uploading files from a content Uri
4 participants