Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proguard-rules.pro for android-23 #234

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Conversation

grantland
Copy link
Contributor

android-23 removed some APIs that our SDK uses internally. Luckily,
we only conditionally use these APIs on older devices so this is
a non-issue for our SDK running on android-23.

This change adds instructions to ignore warnings from proguard stating
that these APIs do not exist when using compileSdkVersion = 23 since
we already have checks in place.

Test Plan:

Change ParseStarterProject's build.gradle:

android {
    compileSdkVersion 23
    useLibrary `org.apache.http.legacy`

    // ...

    buildTypes {
        release {
            minifyEnabled true

            // ...
        }
    }
}

Resolves #231

@facebook-github-bot
Copy link

By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer.

@grantland
Copy link
Contributor Author

ParseApacheHttpClient which uses missing android.net.SSLCertificateSocketFactory only gets used on < android-19: https://github.com/ParsePlatform/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ParseHttpClient.java#L51

NotificationCompatImplBase which uses missing android.app.Notification.setLatestEventInfo only gets used on < android-14: https://github.com/ParsePlatform/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/NotificationCompat.java#L103

@grantland grantland added this to the 1.10.3 milestone Nov 5, 2015
android-23 removed some APIs that our SDK uses internally. Luckily,
we only conditionally use these APIs on older devices so this is
a non-issue for our SDK running on android-23.

This change adds instructions to ignore warnings from proguard stating
that these APIs do not exist when using `compileSdkVersion = 23` since
we already have checks in place.
@grantland grantland force-pushed the grantland.android-23 branch from 52b9ccb to 9e69cb0 Compare November 6, 2015 00:39
sichevoi added a commit to sichevoi/Parse-Starter-Project that referenced this pull request Nov 6, 2015
@wangmengyan95
Copy link
Contributor

LGTM

grantland added a commit that referenced this pull request Nov 6, 2015
Update proguard-rules.pro for android-23
@grantland grantland merged commit 95db225 into master Nov 6, 2015
@grantland grantland deleted the grantland.android-23 branch November 6, 2015 19:41
@facebook-github-bot
Copy link

@grantland updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants