Fixed #7 - Keep WeakReference to parent ParseObject in ParseRelation
#25
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| return null; | ||
| } | ||
| if(parent.get() == null){ | ||
| return ParseDecoder.get().decodePointer(parentClassName, parentObjectId); |
There was a problem hiding this comment.
Let's just use ParseObject.createWithoutData(String, String) instead here so it'll be more concise.
|
This looks awesome! I just have a minor change that you could squash into your current commit and I can merge this in. |
…` in `ParseRelation` As suggested in the issue, keeping reference to parent objectId, className and recreating parent pointer when the parent is GC'ed. All tests passed locally. Fixed parse-community#7 - Keep `WeakReference` to parent `ParseObject` in `ParseRelation` As suggested in the issue, keeping reference to parent objectId, className and recreating parent pointer when the parent is GC'ed. All tests passed locally. Addressing CR comments Merge branch 'parserelation-fix' of https://github.com/sowrabh/Parse-SDK-Android into parserelation-fix
sowrabh
force-pushed
the
parserelation-fix
branch
from
4068716 to
12b6cb0
Compare
|
@grantland Thanks for the quick review. Addressed and squashed. Please have a look. |
Fixed #7 - Keep `WeakReference` to parent `ParseObject` in `ParseRelation`
|
Thanks for your contribution! |
|
@sowrabh If you're interested we'd love to send you some Parse swag as a thank you for your contribution! Just send me an email with your shipping address and t-shirt size, my email is on my GitHub profile page. Thanks again! |
|
@grantland Thanks a bunch. Sent you the details on email. |
|
@sowrabh updated the pull request. |
mtrezza
added
type:feature
|
The label |
parse-github-assistant
bot
removed
the
type:feature
As suggested in the issue, keeping reference to parent objectId, className and recreating parent pointer when the parent is GC'ed.