Fix querying for a ParseObject with JSONArray key #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantland
added
type:bug
| OfflineQueryLogic logic = new OfflineQueryLogic(null); | ||
|
|
||
| ParseQuery.State<ParseObject> query = new ParseQuery.State.Builder<>("SomeObject") | ||
| .whereEqualTo("list", 2) |
There was a problem hiding this comment.
add test .whereEqualTo("list", 4) and make sure it returns false.
|
LGTM. One nits |
`OfflineQueryLogic` was missing the proper code path to compare a value against a `JSONArray`. Added tests for comparing a value against a `List`.
grantland
force-pushed
the
grantland.lds_jsonarray
branch
from
d36a577 to
4fba2cc
Compare
grantland
added a commit
that referenced
this pull request
Aug 14, 2015
Fix querying for a ParseObject with JSONArray key
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OfflineQueryLogicwas missing the proper code path to comparea value against a
JSONArray.Added tests for comparing a value against a
List.