only add client key if non-null #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Any schedule for merge this pull request? |
|
Using |
|
+1 |
|
Can someone help with a test? |
|
I'm going to merge given I'm not able to run tests but will put an issue up for someone who can help. :) |
natario1
added a commit
to natario1/Parse-SDK-Android
that referenced
this pull request
Mar 11, 2017
commit aed49e2 Author: John <jawnnypoo@gmail.com> Date: Thu Mar 9 01:43:57 2017 -0600 Remove Apache dependency to allow for higher Android target SDK. (parse-community#554) * Remove Apache dependency to allow for higher Android target SDK. * Remove ParseURLConnectionHttpClient in favor of ParseOkHttpClient * Add JDK specification to Travis * Assure the latest tools are installed * Update to the latest dependencies * Update so that the notification is built properly commit 93dbb83 Author: Roger Hu <roger.hu@gmail.com> Date: Wed Mar 8 23:26:11 2017 -0800 Bump to 1.14.1 snapshot commit 5bacd08 Author: Roger Hu <roger.hu@gmail.com> Date: Wed Mar 8 17:36:50 2017 -0800 Bump to v1.13.3 release commit 735be49 Author: Mattia <mat.iavarone@gmail.com> Date: Thu Mar 9 02:34:25 2017 +0100 Closing streams in ParseAWSRequest (parse-community#590) * Update ParseAWSRequest.java commit 3fced98 Author: Florent Vilmart <flovilmart@users.noreply.github.com> Date: Wed Mar 8 20:33:32 2017 -0500 Create .codecov.yml (parse-community#594) commit ea489eb Merge: 5434260 b6c98bd Author: Roger Hu <roger.hu@gmail.com> Date: Wed Mar 8 12:15:29 2017 -0800 Merge pull request parse-community#592 from rogerhu/1.13.3 Bump to v1.13.3-SNAPSHOT commit b6c98bd Author: Roger Hu <roger.hu@gmail.com> Date: Wed Mar 8 12:14:17 2017 -0800 Bump to v1.13.3-SNAPSHOT commit 5434260 Merge: 64e74dc 2f2d856 Author: Roger Hu <roger.hu@gmail.com> Date: Wed Mar 8 12:10:59 2017 -0800 Merge pull request parse-community#591 from rogerhu/1.13.2 Bump to v1.13.2 release commit 2f2d856 Author: Roger Hu <roger.hu@gmail.com> Date: Wed Mar 8 12:08:55 2017 -0800 Bump to v1.13.2 release commit 64e74dc Merge: fe08345 f78a722 Author: Roger Hu <roger.hu@gmail.com> Date: Wed Mar 8 12:06:09 2017 -0800 Merge pull request parse-community#506 from posativ/patch-1 only add client key if non-null commit f78a722 Author: Martin Zimmermann <zimmermann@weloveapps.de> Date: Wed Jul 27 14:29:25 2016 +0200 only add client key if non-null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use OkHttp3 and a custom Parser server without a client key (e.g.
nullor no call to the Parse.Configuration.Builder), requests with OkHttp3 will fail due to a null value in the header: Headers.java#L269.