Clean up authData when linkWithAsync() fails #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhartvick
commented
Feb 9, 2018
| @@ -699,13 +699,13 @@ public void testlinkWithInBackgroundWithSaveAsyncFailure() throws Exception { | |||
| partialMockUser.linkWithInBackground(authType, authData); | |||
| linkTask.waitForCompletion(); | |||
|
|
|||
| // Make sure new authData is added | |||
| assertSame(authData, partialMockUser.getAuthData().get(authType)); | |||
There was a problem hiding this comment.
This is the same test/comment from testlinkWithInBackgroundWithSaveAsyncSuccess() above, which makes me think it was expected in the test only because it was copied
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
============================================
+ Coverage 53.34% 53.35% +<.01%
Complexity 1749 1749
============================================
Files 132 132
Lines 10267 10268 +1
Branches 1426 1426
============================================
+ Hits 5477 5478 +1
Misses 4337 4337
Partials 453 453
Continue to review full report at Codecov.
|
|
@rogerhu this seems reasonable as the iOS SDK is performing the same |
flovilmart
approved these changes
Feb 9, 2018
|
Great thanks. |
bitterbit
pushed a commit
to bitterbit/Parse-SDK-Android
that referenced
this pull request
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing
isLinked(myAuthType)to be true after alinkWithAsync()would fail formyAuthType, as explained in #767This PR would make the behavior on both iOS and Android the same.