-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for manifest configuration #809
Remove support for manifest configuration #809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
============================================
- Coverage 54.57% 53.46% -1.12%
+ Complexity 1716 1682 -34
============================================
Files 124 124
Lines 9874 9852 -22
Branches 1384 1380 -4
============================================
- Hits 5389 5267 -122
- Misses 4042 4156 +114
+ Partials 443 429 -14
Continue to review full report at Codecov.
|
.setTag(JOB_TAG_REGISTER) // uniquely identifies the job | ||
.build(); | ||
|
||
Job job = ParseGCMJobService.createJob(dispatcher, gcmSenderFromManifest(context)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're getting read of manifest but keeping it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I tried to get rid of it for the GCM module, but it turns out we need the GCM sender ID at unpredictable times, such as when the token gets refreshed. So, we would either have to keep it in the manifest, or store it in SharedPreferences or something. I think it being in the manifest as it was before is the easiest configuration. Since most should be migrating away from the GCM module anyways, I think it is okay.
Ok we need to update https://docs.parseplatform.org/android/guide/ too... |
The ability to configure the server in the manifest is a sort of relic of when the SDK was being used with Parse.com. In order to move forward with allowing for customization, as well as adding new plugins such as FCM support, I think it is best that in the 1.17.0 release we ditch the Manifest configuration. This is the best time to do it, since 1.17.0 has API breaking changes which, if users are using GCM, will require them to update their Manifest and code anyhow.
We certainly would want to make sure it is clear in the release notes that this is occurring.