Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update parse_server_sdk dependency (fix dependency issue with http) #1000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

2shrestha22
Copy link

@2shrestha22 2shrestha22 commented Jun 13, 2024

Pull Request

Issue

Closes: n/a

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Jun 13, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza
Copy link
Member

mtrezza commented Jun 17, 2024

@mbfakourii I believe you mentioned somewhere that we cannot make this upgrade yet, right? Could you please explain...

@mbfakourii
Copy link
Member

Yes, due to the conflict that exists, this possibility is not available until we support Flutter 3.10.
We have to wait until July 2024 for this upgrade ! [Reference]

@mbfakourii
Copy link
Member

mbfakourii commented Jun 17, 2024

@mbfakourii I believe you mentioned somewhere that we cannot make this upgrade yet, right? Could you please explain...

Yes, due to the conflict that exists, this possibility is not available until we support Flutter 3.10.
We have to wait until July 2024 for this upgrade ! [Reference]

I think it is better to close PR.

@mtrezza
Copy link
Member

mtrezza commented Jun 17, 2024

@2shrestha22 What is the issue that this PR is supposed to fix? Could you help us understand the urgency of this?

@2shrestha22
Copy link
Author

@2shrestha22 What is the issue that this PR is supposed to fix? Could you help us understand the urgency of this?

Many packages have already migrated to use http 1.0.0 but parse sdk still depends on old http package and it makes it impossible to add package dependency.

I didn't understand the conflict. How there can be a conflict with flutter framework?

@mbfakourii
Copy link
Member

mbfakourii commented Jun 18, 2024

@2shrestha22 What is the issue that this PR is supposed to fix? Could you help us understand the urgency of this?

Many packages have already migrated to use http 1.0.0 but parse sdk still depends on old http package and it makes it impossible to add package dependency.

I didn't understand the conflict. How there can be a conflict with flutter framework?

In Flutter version 3.10, when we go to Parse version 7, we encounter conflicts in some packages.

Check this PR and check this fail ci.

@ebsangam
Copy link

ebsangam commented Jun 18, 2024

@2shrestha22 What is the issue that this PR is supposed to fix? Could you help us understand the urgency of this?

Many packages have already migrated to use http 1.0.0 but parse sdk still depends on old http package and it makes it impossible to add package dependency.
I didn't understand the conflict. How there can be a conflict with flutter framework?

In Flutter version 3.10, when we go to Parse version 7, we encounter conflicts in some packages.

Check this PR and check this fail ci.

We can fix it by updating the Dart SDK constraint in parse_server_sdk_flutter. Why waiting?
image

@ebsangam
Copy link

Is there any reason we are not updating the Dart SDK constraint to sdk: ">=3.0.7 <4.0.0"?

@mbfakourii
Copy link
Member

Is there any reason we are not updating the Dart SDK constraint to sdk: ">=3.0.7 <4.0.0"?

Please check our Flutter support policy and Dart support policy .

@ebsangam
Copy link

That means we are always stuck with old package version? What if developers gets in situation like me and can't use a package due to no support for latest versions? It has been a year since http v1.0.0 got released and if there is any package that depends on http v1.0.0 which almost all package will since it has been a year long then we can't use the package. This may not be a good way of handling backward compatibility as Flutter is evolving and in a year there can be lots of changes which will be very difficult to migrate upon if not done gradually.

@mbfakourii
Copy link
Member

That means we are always stuck with old package version? What if developers gets in situation like me and can't use a package due to no support for latest versions? It has been a year since http v1.0.0 got released and if there is any package that depends on http v1.0.0 which almost all package will since it has been a year long then we can't use the package. This may not be a good way of handling backward compatibility as Flutter is evolving and in a year there can be lots of changes which will be very difficult to migrate upon if not done gradually.

We discussed this a lot before (you can search about it in the repository) and our support policy is currently in this form.
You can use dependency_overrides temporarily.

@ebsangam
Copy link

I don't think dependency override is good thing to do when there are breaking changes.

@pastordee
Copy link
Contributor

Since flutter is still evolving, is it possible to change our policy to say every four months for now?

Because I think a year is just too long for us to update the package.

@mbfakourii
Copy link
Member

mbfakourii commented Jun 18, 2024

Please check this issues.

@mtrezza
Copy link
Member

mtrezza commented Jun 19, 2024

Please everyone feel free to revive the discussion in #968 about our support policy and we'll reopen the issue. See the arguments there that have been made to reach the current support policy.

@2shrestha22
Copy link
Author

The support policy is not helping developers. Avoiding latest update for old flutter support does look like a good idea. I never seen any packages doing this. May be we need different policy of flutter package.

@2shrestha22
Copy link
Author

If you still want to have those policy just remember node and flutter aren't same. Node have lts support but flutter doesn't. Flutter is cutting edge tool. We shouldn't fight with framework.

@mtrezza
Copy link
Member

mtrezza commented Jun 20, 2024

We can reopen the discussion in #968 if someone wants to respond on the tread there. Please consider the arguments already made there. We will certainly consider any counter arguments that justify a policy change.

@valerycolong
Copy link

valerycolong commented Sep 22, 2024

Anyone still facing this issue with http: ^0.13. dependency in Sep 2024?

I think I fixed it with dependency overrides. It would appear current version of parse_server_sdk package is up to date with its dependencies but parse_server_sdk_flutter depends on an older version of parse_server_sdk which is not up to date with its dependencies.

Adding this to pubspec.yml did the trick for me.

dependency_overrides:
  parse_server_sdk: ^7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants