Skip to content

Conversation

@yulingtianxia
Copy link
Contributor

ParseGeoPoint should be simple.
This PR could fix some issue about saving objects. (#195 (comment))

@RodrigoSMarques
Copy link
Contributor

@yulingtianxia
ParseGeoPoint is not a Parse object is a data type and therefore does not extend ParseObject Class.

It is not necessary to change the parse_encode functions to put .toJson () because this method is already called by default.

This code is working properly today. I have made all the adjustments and tests.

I'm building an app that uses all these functions and everything is ok.

@yulingtianxia
Copy link
Contributor Author

@RodrigoSMarques
OMG, it's a mistake. I'll delete the two lines.

@RodrigoSMarques
Copy link
Contributor

No need toJson. When you call the jsonEncode method it is already called by default in value

https://api.dartlang.org/stable/2.4.0/dart-convert/jsonEncode.html

@yulingtianxia
Copy link
Contributor Author

@RodrigoSMarques
Thank you for your correction!
There is something wrong with my git merge. It's not intensional to add toJson. I had deleted it.

@phillwiggins phillwiggins merged commit 7c97afb into parse-community:release/1.0.22 Jun 18, 2019
@yulingtianxia yulingtianxia deleted the fix_save branch June 19, 2019 08:07
fischerscode pushed a commit to fischerscode/Parse-SDK-Flutter that referenced this pull request Sep 5, 2020
* Fix Commit: 6ed26e1

* Update parse_encoder.dart

Fix parse encoder bug.

* Fix exception when sendSessionId is null.

* Fix GeoPoint.

* delete useless code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants