Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ParseUser.save fails when user is logged in #822

Merged
merged 5 commits into from
Feb 15, 2023
Merged

fix: ParseUser.save fails when user is logged in #822

merged 5 commits into from
Feb 15, 2023

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Feb 13, 2023

New Pull Request Checklist

Issue Description

fix save user

Closes: #819

Approach

Use the new method to send Json in fromJson

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 13, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mbfakourii mbfakourii requested a review from a team February 13, 2023 06:57
@mbfakourii mbfakourii changed the title Fix bug save user fix: bug save user Feb 13, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: bug save user fix: Bug save user Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 15.86% // Head: 15.88% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1bf66d6) compared to base (664689c).
Patch coverage: 40.00% of modified lines in pull request are covered.

❗ Current head 1bf66d6 differs from pull request most recent head d3b7d2e. Consider uploading reports for the commit d3b7d2e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   15.86%   15.88%   +0.01%     
==========================================
  Files          47       47              
  Lines        2861     2865       +4     
==========================================
+ Hits          454      455       +1     
- Misses       2407     2410       +3     
Impacted Files Coverage Δ
packages/dart/lib/src/objects/parse_base.dart 46.49% <40.00%> (-0.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title fix: Bug save user fix: ParseUser.save fails when user is logged in Feb 13, 2023
@mtrezza
Copy link
Member

mtrezza commented Feb 13, 2023

Is this bug only affecting ParseUser.save, or does it also affect other objects? Could you give more details about the issue, so we can write a proper PR title / changelog entry?

@mbfakourii
Copy link
Member Author

Is this bug only affecting ParseUser.save, or does it also affect other objects? Could you give more details about the issue, so we can write a proper PR title / changelog entry?

This error is related to fromJson when server json values want to be converted to local model

packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit b07ce8c into parse-community:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseUser.save fails when user is logged in
2 participants