-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating and deleting a ParseObject sends requests even if object ID is null #829
Conversation
… server even when the objectId property is null
Thanks for opening this pull request!
|
Codecov ReportBase: 15.82% // Head: 15.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 15.82% 15.78% -0.04%
==========================================
Files 47 47
Lines 2876 2883 +7
==========================================
Hits 455 455
- Misses 2421 2428 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I will write the tests for these changes in my other PR. When these changes are approved and merged into the master I will pull them to my code base and write tests for them |
I will reformat the title to use the proper commit message syntax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code was tested and looks good
Since this is a fix, could you add a change log entry using the title of this PR and bump the version? It would also be great if you could add a test for the bug that is fixed here, so we can prevent this from happening in the future. |
Adding tests now will create a merge conflict on my other PR. I will add tests for this on my other PR. I'm adding tests for every function in |
Got it, thanks for adding the changelog entry, let's wait for the CI and then merge this... |
New Pull Request Checklist
Issue Description
Closes: #828
Approach
Use
assert()
to make sure that theobjectId
is valid and can be usedTODOs before merging