-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade various dependencies and fix warnings in Flutter package #844
feat: Upgrade various dependencies and fix warnings in Flutter package #844
Conversation
Thanks for opening this pull request!
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
=======================================
Coverage 26.35% 26.35%
=======================================
Files 47 47
Lines 2903 2903
=======================================
Hits 765 765
Misses 2138 2138
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@mtrezza |
It's probably a minimum coverage that is expects? |
No, by the way, many lines say to write a test, which is not necessary |
Let's look at the coverage in a separate issue then. |
This is a breaking change, as it upgrades to nio 5 and parse dart 4. So I'd merge this together with the breaking change of package renaming. Other than that it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mtrezza |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a changelog entry
Once this is merged, we can publish the flutter 4.0 release. |
…ate_flutter_version # Conflicts: # packages/flutter/CHANGELOG.md
flutter version bumped and entry added in CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To give more details about the changelog convention we're using across Parse Platform:
- a
feat
PR must have an entry in the### Features
section which is (except in specific cases) the same as the PR title - the
### BREAKING CHANGES
section is an additional section in which a PR that includes a breaking change must make a note in addition to the entry in the### Features
section; it's where more details can be added to help developers adapt to the breaking change, such as links to migration guides, other GitHub issues, etc. - the entries mentioned above always reference the GitHub pull request, not the GitHub issue; that's because a commit may not have an issue associated with it, but it (usually) always has a pull request; in the past we were sometimes referencing issues which we don't do anymore.
I'll commit the changes.
Are we ready to release Flutter 4.0 after this PR has been merged?
Yes, we are ready for 4.0.0 |
Great, let's wait for @mbfakourii's confirmation as well, then I'll go ahead and merge. |
For now, let's move to a higher version. We need more time to discuss the merge of the two libraries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
New Pull Request Checklist
Issue Description
All versions and packages in the Flutter package have been updated to the latest version and the warnings have been fixed
Closes: #821
Approach
n/a
TODOs before merging