Skip to content

fix: Malformed JSON in whereMatchesQuery #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtrezza merged 3 commits into from
Jul 18, 2023
Merged

fix: Malformed JSON in whereMatchesQuery #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80a0318
Fix malformed JSON in _buildQueryRelational
juriSacchetta Jul 15, 2023
376e9a9
Updated lib version and added CHANGELOG.md entry
juriSacchetta Jul 18, 2023
6f31021
Update packages/dart/CHANGELOG.md
mtrezza Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/dart/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## [5.1.3](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-5.1.2...dart-5.1.3) (2023-07-18)

### Bug Fixes

* Malformed JSON in `whereMatchesQuery` ([#955](https://github.com/parse-community/Parse-SDK-Flutter/pull/955))

## [5.1.2](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-5.1.1...dart-5.1.2) (2023-05-29)

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion packages/dart/lib/src/base/parse_constants.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
part of flutter_parse_sdk;

// Library
const String keySdkVersion = '5.1.2';
const String keySdkVersion = '5.1.3';
const String keyLibraryName = 'Flutter Parse SDK';

// End Points
Expand Down
3 changes: 2 additions & 1 deletion packages/dart/lib/src/network/parse_query.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ class QueryBuilder<T extends ParseObject> {
/// Builds the query relational for Parse
String _buildQueryRelational(String className) {
queries = _checkForMultipleColumnInstances(queries);
return '{"where":{${buildQueries(queries)}},"className":"$className",${getLimitersRelational(limiters)}}';
String lim = getLimitersRelational(limiters);
return '{"where":{${buildQueries(queries)}},"className":"$className"${limiters.isNotEmpty ? ',"$lim"' : ''}}';
}

/// Builds the query relational with Key for Parse
Expand Down
2 changes: 1 addition & 1 deletion packages/dart/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: parse_server_sdk
description: The Dart SDK to connect to Parse Server. Build your apps faster with Parse Platform, the complete application stack.
version: 5.1.2
version: 5.1.3
homepage: https://github.com/parse-community/Parse-SDK-Flutter

environment:
Expand Down
3 changes: 2 additions & 1 deletion packages/dart/test/src/network/parse_query_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'dart:convert';

import 'package:mockito/annotations.dart';
import 'package:mockito/mockito.dart';
import 'package:parse_server_sdk/parse_server_sdk.dart';
Expand Down Expand Up @@ -463,7 +464,7 @@ void main() {
)).captured.single);

// assert
expect(result.query.contains("%22object2%22,%22include%22"), true);
expect(result.query.contains("%22object2%22,%22%22include%22"), true);
});

test('the result query should contains encoded special characters values',
Expand Down