-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade connectivity_plus
#974
refactor: Upgrade connectivity_plus
#974
Conversation
refactor: Add `CONTRIBUTING.md`
Thanks for opening this pull request! |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #974 +/- ##
=======================================
Coverage 40.60% 40.60%
=======================================
Files 60 60
Lines 3401 3401
=======================================
Hits 1381 1381
Misses 2020 2020 ☔ View full report in Codecov by Sentry. |
connectivity plus
connectivityـplus
connectivityـplus
connectivity_plus
connectivity_plus
connectivity plus
connectivity plus
connectivity_plus
You can close and re-open the PR to re-run the CI. Why do you need to re-run the CI in the first place, do we have a flaky test? |
In this action run, I encountered a codecov error and had to run CI again ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, this is only an internal package, so no breaking change?
The CI issue looks like a temporary service issue that self-resolved.
No, there is no problem, I think it is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this should be released immediately then the fix
PR requires a changelog entry. Otherwise you can make it a refactor
to release it with the next fix
or feat
PR.
connectivity_plus
connectivity_plus
I think it is a |
Pull Request
Issue
Closes: #972
Approach
Upgrade
connectivity plus
to5.0.1
Tasks