Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade connectivity_plus #974

Merged
merged 18 commits into from
Oct 19, 2023
Merged

refactor: Upgrade connectivity_plus #974

merged 18 commits into from
Oct 19, 2023

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

Closes: #972

Approach

Upgrade connectivity plus to 5.0.1

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9431086) 40.60% compared to head (2ea5cab) 40.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #974   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files          60       60           
  Lines        3401     3401           
=======================================
  Hits         1381     1381           
  Misses       2020     2020           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbfakourii mbfakourii requested a review from a team October 17, 2023 14:23
@mbfakourii
Copy link
Member Author

mbfakourii commented Oct 17, 2023

@mtrezza

Can you give me access to execute the CI file?
I have to commit again to run CI! [1]

@mbfakourii mbfakourii changed the title fix: Upgrade connectivity plus fix: Upgrade connectivityـplus Oct 17, 2023
@mbfakourii mbfakourii changed the title fix: Upgrade connectivityـplus fix: Upgrade connectivity_plus Oct 17, 2023
@mbfakourii mbfakourii changed the title fix: Upgrade connectivity_plus fix: Upgrade connectivity plus Oct 17, 2023
@mbfakourii mbfakourii changed the title fix: Upgrade connectivity plus fix: Upgrade connectivity_plus Oct 17, 2023
@mtrezza
Copy link
Member

mtrezza commented Oct 18, 2023

You can close and re-open the PR to re-run the CI. Why do you need to re-run the CI in the first place, do we have a flaky test?

@mbfakourii
Copy link
Member Author

mbfakourii commented Oct 18, 2023

You can close and re-open the PR to re-run the CI. Why do you need to re-run the CI in the first place, do we have a flaky test?

In this action run, I encountered a codecov error and had to run CI again !

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is only an internal package, so no breaking change?

The CI issue looks like a temporary service issue that self-resolved.

@mbfakourii
Copy link
Member Author

Looks good, this is only an internal package, so no breaking change?

The CI issue looks like a temporary service issue that self-resolved.

No, there is no problem, I think it is ready for merge.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this should be released immediately then the fix PR requires a changelog entry. Otherwise you can make it a refactor to release it with the next fix or feat PR.

@mbfakourii mbfakourii changed the title fix: Upgrade connectivity_plus refactor: Upgrade connectivity_plus Oct 19, 2023
@mbfakourii
Copy link
Member Author

mbfakourii commented Oct 19, 2023

If this should be released immediately then the fix PR requires a changelog entry. Otherwise you can make it a refactor to release it with the next fix or feat PR.

I think it is a refactor and there is no need for versioning.

@mtrezza mtrezza merged commit f757dad into parse-community:master Oct 19, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update your packages
2 participants