Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Dart 3.1, 3.2, 3.3; remove support for Dart 2.19 #993

Merged

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

Closes: #992

Approach

n/a

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

@mbfakourii mbfakourii requested a review from mtrezza April 2, 2024 06:46
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 43.37%. Comparing base (c388545) to head (283af26).
Report is 1 commits behind head on master.

❗ Current head 283af26 differs from pull request most recent head 5c11e03. Consider uploading reports for the commit 5c11e03 to get more accurate results

Files Patch % Lines
packages/dart/lib/src/utils/parse_live_list.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   43.37%   43.37%           
=======================================
  Files          61       61           
  Lines        3463     3463           
=======================================
  Hits         1502     1502           
  Misses       1961     1961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbfakourii mbfakourii requested review from mtrezza and removed request for mtrezza April 7, 2024 18:17
@mtrezza
Copy link
Member

mtrezza commented Apr 7, 2024

This is a breaking change since we are removing support for older dart versions, right? Could you please rename the PR title to

feat: Add support for Dart x.x, x.x; remove support for Dart x.x, x.x

@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Apr 7, 2024
@mbfakourii mbfakourii changed the title docs: Compatibility update in Dart feat: Add support for Dart 3.1,3.2,3.3; remove support for Dart 2.19 Apr 8, 2024
@mbfakourii mbfakourii changed the title feat: Add support for Dart 3.1,3.2,3.3; remove support for Dart 2.19 feat: Add support for Dart 3.1,3.2,3.3; remove support for Dart 2.19 Apr 8, 2024
@mbfakourii mbfakourii changed the title feat: Add support for Dart 3.1,3.2,3.3; remove support for Dart 2.19 feat: Add support for Dart 3.1, 3.2, 3.3; remove support for Dart 2.19 Apr 8, 2024
@mbfakourii
Copy link
Member Author

This is a breaking change since we are removing support for older dart versions, right? Could you please rename the PR title to

feat: Add support for Dart x.x, x.x; remove support for Dart x.x, x.x

Yes, the title has also changed.

@mtrezza
Copy link
Member

mtrezza commented Apr 8, 2024

Could you add the changelog entry?

Features:
- ...

Breaking Changes:
- Removes support for Dart ...

@mbfakourii
Copy link
Member Author

Could you add the changelog entry?

Features:
- ...

Breaking Changes:
- Removes support for Dart ...

Added.

@mbfakourii
Copy link
Member Author

CI errors are related to codecov.

packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved
@mtrezza mtrezza merged commit 98f4a26 into parse-community:master Apr 12, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package connectivity_plus is old
2 participants