fix: reject request promise if remove server is unavailable #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
igor-lemon
force-pushed
the
issue-1417
branch
from
a5ae8e6 to
bced4d7
Compare
igor-lemon
changed the title
|
Hi @mtrezza! Can you check the PR? |
|
@igor-lemon it seems the build is failing, could you take a look? apologies for the long wait... |
igor-lemon
force-pushed
the
issue-1417
branch
from
bced4d7 to
4cda1fb
Compare
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
igor-lemon
force-pushed
the
issue-1417
branch
from
4cda1fb to
405c2db
Compare
igor-lemon
force-pushed
the
issue-1417
branch
from
405c2db to
6fbc3de
Compare
|
@igor-lemon I noticed that you closed this PR, did you wait for a review? |
|
Sorry, the PR is not actual. The problem was not in the promise rejecting, the problem was at the request retries and timeout between each other. It looked like infinity waiting and blocked an app. The SDK tries to make 5 reconnect attempts with increasing time between each request. I solved it at my side by setting max 3 retries. It solved my problem Parse.CoreManager.set('REQUEST_ATTEMPT_LIMIT', 3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Reject promise when remote parse server is unavailable
Related issue: #1417