Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Run Prettier for TypeScript declaration files #2142

Merged
merged 1 commit into from
May 18, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 18, 2024

Pull Request

Issue

TypeScript declaration files .d.ts are generated with tabs instead of spaces and other formatting issues. This will cause dtslint to fail. Running Prettier + Lint --fix against these files leaves only type correctness checks and tests.

Screenshot 2024-05-17 at 5 39 43 PM

Approach

Converts the following files to TS

FacebookUtils
ParseConfig
ParseOp
ParsePolygon
ParseSchema
  • Add Facebook types for global FB variable
  • Fixes the Check Types CI Job, this can now be a required job before merging PRs
  • Add TS test suite example

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented May 18, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (f782ce0).
Report is 48 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2142    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6371   +185     
  Branches      1499      1511    +12     
==========================================
+ Hits          6186      6371   +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team May 18, 2024 21:25
@mtrezza mtrezza mentioned this pull request May 18, 2024
66 tasks
@mtrezza
Copy link
Member

mtrezza commented May 18, 2024

Quite impressive

@mtrezza mtrezza merged commit 09a2d0b into parse-community:alpha May 18, 2024
11 checks passed
@dplewis dplewis deleted the prettier-dts branch May 18, 2024 21:34
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 7, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 24, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants