refactor: Replace require with import statement #2143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
The compilers cannot optimize the imports and remove unused code.
See discussion #1399
Approach
The only files using
require
are as follows:CryptoController - Babel doesn't strip out unused imports
EventEmitter - Babel doesn't strip out unused imports
ParseFile - Can't use ES6 modules like https and http
RESTController - xmlhttprequest node package can't be imported
CoreManager - Can't get package version from package.json using import
Convert the following files to TS