Support includeAll Query #632
Conversation
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 84.98% 85.07% +0.08%
==========================================
Files 48 48
Lines 3850 3853 +3
Branches 871 871
==========================================
+ Hits 3272 3278 +6
+ Misses 578 575 -3
Continue to review full report at Codecov.
|
|
Can we use the '*' as an include argument? and perhaps includeAll being a shorthand for that? This will be easier to handle on the server also instead of a new parameter. |
dplewis
changed the title
|
@flovilmart This is what you mean right? |
|
I mean to treat include all as just using |
|
I'll make an update server side. While preserving parse-community/parse-server#4838 |
dplewis
changed the title
src/ParseQuery.js
Outdated
| @@ -1313,6 +1315,10 @@ class ParseQuery { | |||
| /** | |||
| * Includes nested Parse.Objects for the provided key. You can use dot | |||
| * notation to specify which fields in the included object are also fetched. | |||
| * | |||
| * If you want to include all nested Parse.Objects pass in '*' | |||
| * <pre>query.include('*');</pre> | |||
There was a problem hiding this comment.
perhaps we need to put a version number here?
There was a problem hiding this comment.
I have no idea mate which version is, I can try to backtrack
There was a problem hiding this comment.
Ok ok, so basically it already works if you pass include All in the rest SDK.
There was a problem hiding this comment.
Yes that is correct. Basically this won't work until the next release unless I re-add includeAll to this SDK
There was a problem hiding this comment.
Yeah, let’s just use the * notation then we’ll perhaps be able to expand on with reg ex etc...
There was a problem hiding this comment.
How best can we update the guides simultaneously with the API docs
src/ParseQuery.js
Outdated
| @@ -1313,6 +1315,10 @@ class ParseQuery { | |||
| /** | |||
| * Includes nested Parse.Objects for the provided key. You can use dot | |||
| * notation to specify which fields in the included object are also fetched. | |||
| * | |||
| * If you want to include all nested Parse.Objects pass in '*' | |||
| * <pre>query.include('*');</pre> | |||
|
@flovilmart can this be merged? |
parse-community/parse-server#4838
provides shorthand for include('*')