Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #8

Closed
MarvinNazari opened this issue Aug 13, 2015 · 42 comments
Closed

Carthage support #8

MarvinNazari opened this issue Aug 13, 2015 · 42 comments
Labels
type:feature New feature or improvement of existing feature
Milestone

Comments

@MarvinNazari
Copy link

Would be awesome to have Carthage support.

@nlutsenko nlutsenko self-assigned this Aug 13, 2015
@nlutsenko
Copy link
Contributor

Hey @MarvinNazari,
Thanks! Definetly, would be great, we'll get there shortly.

@KyleLeneau
Copy link

💯 👍

@KyleLeneau
Copy link

So I just tried this and it seems to be working... What else is needed to be done?

@dgrekov
Copy link

dgrekov commented Aug 18, 2015

works for me as well

@bojanstef
Copy link

I wrote this in my Cartfile and it didn't work...

github "ParsePlatform/Parse-SDK-iOS-OSX" ~> 1.8.1 # FB Parse compatible with version 1.8.1

The error message was: https://gist.github.com/bojanstef/2544b0f7b5273121ca42

Any suggestions?

@kyledecot
Copy link

Doesn't work for me. I'm getting the following when doing a carthage update

*** Building scheme "Parse-OSX" in Parse.xcworkspace
** BUILD FAILED **


The following build commands failed:
    ExternalBuildToolExecution BoltsSDK-OSX
(1 failure)
A shell task failed with exit code 65:
** BUILD FAILED **


The following build commands failed:
    ExternalBuildToolExecution BoltsSDK-OSX
(1 failure)

@schwa
Copy link

schwa commented Sep 16, 2015

👍

Looks like Bolts framework is a fake static framework.

Carthage only works with dynamic frameworks.

@dgrekov
Copy link

dgrekov commented Sep 16, 2015

While the main branch is not yet fully compatible with Carthage or iOS9 Bitcode, you can use my branch for Carthage

github "dgrekov/Parse-SDK-iOS-OSX"

@nlutsenko
Copy link
Contributor

That's great! Would love to see a PR for this!
master branch is fully compatible with bitcode, though.

@dgrekov
Copy link

dgrekov commented Sep 16, 2015

Yes, the changes that I have made center mainly around project configuration and making a bitcode compatible Bolts build. Let me look to see how I can make it a clean pull request and make it happen.

For reference, bolts is at: github "dgrekov/Bolts-iOS"

@exalted
Copy link

exalted commented Sep 26, 2015

@dgrekov I added following lines in Cartfile:

github "dgrekov/Bolts-iOS" "358dd4ee49b9befb76c3005327ea417c4197bfa8"
github "dgrekov/Parse-SDK-iOS-OSX" "b532ee86b83bf865ad9386aead3e4aeba06e3ee0”

… and still get:

*** Building scheme "Parse-OSX" in Parse.xcworkspace
** BUILD FAILED **


The following build commands failed:
    ExternalBuildToolExecution BoltsSDK-OSX
(1 failure)

How am I supposed to try this instead?

Thanks.

@danstepanov
Copy link

@dgrekov @nlutsenko where did things land with this pull request #281

I'm trying to get my cartfile to work with

github "ParsePlatform/Parse-SDK-iOS-OSX" == 1.8.3

Dimitry's fork only goes up to 1.8.1.7. Does this mean that there is currently no Swift 2.0, Xcode 7, Carthage compatible version of the Parse iOS SDK?

@nlutsenko
Copy link
Contributor

@danstepanov There is no Carthage compatible version for iOS indeed.
There is some work being done in #600 by @flovilmart to make this happen though.

@nlutsenko
Copy link
Contributor

Though we are fully compatible with Swift 2.0/2.1, Xcode 7 and friends...

@dgrekov
Copy link

dgrekov commented Nov 25, 2015

Currently, there is no way to build the framework using Carthage. I am exploring the use of the framework zip file and will update the thread as I know more.

@flovilmart
Copy link
Contributor

I'm working on it as we speak, with a clean rake build script that would build both Bolts and Parse as dylibs and compatible with Carthage

@lolagin
Copy link

lolagin commented Dec 4, 2015

So at present, if I want to use the parse framework in a project actively using carthage, do I just need to manually import it? Can carthage work with cocoapods and those xcworkspaces?

@pigeondotdev
Copy link

Any updates on Carthage support?

@flovilmart
Copy link
Contributor

You Can get it from here, https://github.com/flovilmart/ParseKit the supported versions are detailed in the readme. PR are welcome for updating to the latest versions of submodules.

This repo essentially builds all the dependencies, including FBSDK, as proper modules through custom configurations at build time.

@nlutsenko
Copy link
Contributor

Official update: it's coming very soon, targeting next or one after release (before end of year or in first week of new year).
Since I want to rollout the compatibility for every platform (iOS/OSX/watchOS/tvOS), there are some changes required in Bolts.framework to make it happen (pending review right now).

@nlutsenko
Copy link
Contributor

Add the following to your Cartfile:
github "ParsePlatform/Parse-SDK-iOS-OSX" "master"

P.S. I would recommend waiting until the release of 1.12.0, since both the PR and this issue is attributed with such.

@fbartho
Copy link

fbartho commented Jan 5, 2016

Thanks @nlutsenko. I'm actually just starting a brand new project -- first from scratch-scratch in a while. I didn't want to use Cocoa Pods, but am totally new to looking at Carthage.

My timeline is such that I'm certain 1.12.0 will be released way before my project is. :)

@exalted
Copy link

exalted commented Jan 5, 2016

I think some basic setup instructions in README would be nice to have for Carthage at this point.

What do you think?

@pigeondotdev
Copy link

^ 👍

@nlutsenko
Copy link
Contributor

Agreed, will update the README with release of 1.12.0, since we didn't release the new version yet.

@AndrewSB
Copy link
Contributor

AndrewSB commented Jan 6, 2016

@nlutsenko @flovilmart: I'm transitioning over from @flovilmart branch to this master repo, any idea on how to integrate everything else @flovilmart was offering through Carthage?

  • FBSDKCoreKit.framework
  • FBSDKLoginKit.framework
  • FBSDKShareKit.framework
  • ParseFacebookUtilsV4.framework
  • ParseTwitterUtils.framework

Any ideas? Hoping that over time ParsePlatform will modularize all of the repos (relevant https://github.com/ParsePlatform/ParseFacebookUtils-iOS/issues/21 & https://github.com/ParsePlatform/ParseTwitterUtils-iOS/issues/18), and then maybe, a while later, the FBSDK can come around too

@nlutsenko
Copy link
Contributor

ParseTwitterUtils - on it.
ParseFacebookUtils - outside of rolling out your own support for this, unless FBSDK***Kit supports it, we can't quite make it work.

@flovilmart
Copy link
Contributor

@AndrewSB you could still use the other kits without Parse, now that Parse is offering the Carthage support, I can remove it from the repo to only build the FB dependencies, including ParseFacebookUtilsV4.framework, also passing a custom XC_CONFIG_FILE to carthage, that may be possible to force building the FBSDK's as dynamic module. I'll investigate that option

@AndrewSB
Copy link
Contributor

AndrewSB commented Jan 7, 2016

@nlutsenko awesome! what do you think are the odds that Facebook will decide to support Carthage? Slim to none?

@flovilmart that would be awesome. Thank you for maintaining that 😄

@nlutsenko
Copy link
Contributor

@AndrewSB, as I work at FB 😁, let me try to get it done, so there is a good chance it will happen, though I don't have a timeline for it.

@AndrewSB
Copy link
Contributor

AndrewSB commented Jan 7, 2016

Wasn't sure how much pull you had there 😛
Unfamiliar with how close the parse team is with the rest of Facebook/Facebook mobile teams.

That would be super cool, keep us updated!

@danstepanov
Copy link

Thank you young based @nlutsenko

@Bogidon
Copy link

Bogidon commented Jan 8, 2016

When I build Parse with Carthage I only get an OSX framework and no iOS one. Am I doing something wrong?

@nlutsenko
Copy link
Contributor

@Bogidon, use the master branch since it's already merged or the next release, since there is still no tag that supports Carthage (the release is coming tomorrow).

@Bogidon
Copy link

Bogidon commented Jan 8, 2016

@nlutsenko How can I tell Carthage to use the master branch? (does it not do this by default?)

@nlutsenko
Copy link
Contributor

@Bogidon Nope, it should use the latest tag avaiable.
Add the following to your Cartfile to use master branch:

github "ParsePlatform/Parse-SDK-iOS-OSX" "master"

@Bogidon
Copy link

Bogidon commented Jan 8, 2016

@nlutsenko sorry for the trouble but now I'm getting this error:
Scheme Bolts-tvOS is not currently configured for the build action.

I'm up-to-date with Carthage, Xcode and OS X.

@Bogidon
Copy link

Bogidon commented Jan 8, 2016

I deleted my Carthage folder and ran carthage update again and now it works. Thanks for the help @nlutsenko, looking forward to the release tomorrow 😄

@kirank-canwill
Copy link

I have update latest Parse version 1.12.0, but it freeze UI while using Live and Local query. can you please help me.

@pigeondotdev
Copy link

@kirank-canwill Unrelated to Carthage. Can you file another issue for this problem? We'll also need more details to provide any assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests