-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for bitcode and ios9 #281
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Amazing! This looks like a great start! |
This references issue #8 by the way. Agree with the challenge of supporting ios7, however it seems that static frameworks will not allow the app to compile with bitcode enabled, will explore further and will update this PR as I can identify more details. |
I will also look to revise the PR based on the above comments, thank you for your feedback. |
Actually, we have bitcode support using static frameworks for SDK versions starting from 1.8.3. |
Converted the build to a dynamic framework, enabled bitcode, unfortunately, could not figure out how to make Bolts build automatically.