Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for bitcode and ios9 #281

Closed
wants to merge 9 commits into from

Conversation

dgrekov
Copy link

@dgrekov dgrekov commented Sep 17, 2015

Converted the build to a dynamic framework, enabled bitcode, unfortunately, could not figure out how to make Bolts build automatically.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@nlutsenko
Copy link
Contributor

Amazing! This looks like a great start!
One of the things that is very important for us is that we want to make sure that iOS 7.0 still is supported os version and as a result - Static Framework on iOS probably still need to be there.

@dgrekov
Copy link
Author

dgrekov commented Sep 17, 2015

This references issue #8 by the way.

Agree with the challenge of supporting ios7, however it seems that static frameworks will not allow the app to compile with bitcode enabled, will explore further and will update this PR as I can identify more details.

@dgrekov
Copy link
Author

dgrekov commented Sep 17, 2015

I will also look to revise the PR based on the above comments, thank you for your feedback.

@nlutsenko
Copy link
Contributor

Actually, we have bitcode support using static frameworks for SDK versions starting from 1.8.3.

@dgrekov dgrekov closed this Oct 3, 2015
@danstepanov danstepanov mentioned this pull request Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants