Class properties #1400
Merged
Class properties #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toto If you happen to be interested in being a maintainer of this repo I think it would be very welcome as you have made some great contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the declaration of class properties in the headers from
+ (Type)propertyand+ (void)setProperty:(Type)value;to the more modern@property (class) Type propertywhere appropriate.This has the main advantage of allowing the Swift compiler to differentiate between a property and a method, removing errors like
foo.barinstead offoo.bar()in Swift.This should not affect ObjC behaviour in any way.
In the wake of this I renamed some class methods from
getFootofooto keep in line with property naming. The old names are now marked as deprecated.