Fixing nightly build.

[noobs2ninjas]

• Updated xctoolchain checkout in gitmodules
• Removed unnecessary code that creates duplicate tvOS simulators

[noobs2ninjas]

@drdaz or @TomWFox If you want to verify. I created this branch and then copied the nightly build code to run on commit. You can see the successful test here. Now that its passed I have returned the project back to normal only building PR and commits to master.

[TomWFox]

Looks like there is something funny going on with the iOS build now.

[noobs2ninjas]

Not sure what happened. Was a bundler error or something. I just reran it and it seems to have built just fine.

[drdaz]

Sorry this got away from me. I've been distracted by, amongst other things, the entire world stopping.

I came to try and fix the nightly, but found this.

I feel like it's a problem that what we test on our PRs isn't quite the same as what we do against master. Is there any reason why we don't run the same targets as the nightlies on our PRs before we merge? I feel like it creates surprises.

Anybody know how to add it to the PR tests?

[drdaz]

That comment sounded all negative. This looks like great work 👍🏼

[drdaz]

@noobs2ninjas Is there some kind of cat and mouse game going on with the Simulator versions and our config here? As in, do we need to keep updating them?

I ask since I think I remember seeing an option to predefine which Simulators were available on the machine. We could get stability that way.

[noobs2ninjas]

@drdaz

Theres been a lot of issues going on between Travis and Circle.
One issue was Travis changed the default version of iOS changed on the same environment with no warning. So where Xcode 11 had 12.0 all the sudden it changed to 12.1.2 and began failing. When we updated that all the sudden we had to update some of our bundle versions for it to be compatible with that environments new ruby version which then new gems deprecated certain verbiage which we had to update. Then we had to manually add OCMock to our project for the builds which updated the projects Xcode version again which then caused another environment update. Then all the sudden for some reason Travis began adding its own tvOS simulator by default making our script incompatible causing yet another update to our scripts. Also with each environment update changed the name of the simulators. The release of the iPhone 11 changed which simulators where available by default. Just one thing after another.

I'm hoping this is the end of it. I'll admit that some of the early adjustments have been due to just me learning. Recently though its like conducting an orchestra with no experience and the time signature keeps changing every 4 measures. Music analogy...check.

I plan on leaving this setup on there until we are absolutely forced to update again. The only update I see happening is when we update the pod spec with the new bolts version once that is released.