Release 1.18.0 #1494

noobs2ninjas · 2020-04-13T15:43:13Z

Updated Changelog for 1.18.0
Fixed a small issue with a info.plist giving the wrong minimum SDK version.

…18.0.

noobs2ninjas · 2020-04-13T15:48:15Z

@TomWFox Hey could you look at my changelog and give me your opinion about how I did. Let me know if you think I got too much or too little. Also, is nextrelease from the new forum or has that been around for a little while.

noobs2ninjas · 2020-04-13T15:59:11Z

Also, I cant create tags for new versions on this page. Only like issue tags. https://github.com/parse-community/Parse-SDK-iOS-OSX/tags

TomWFox · 2020-04-13T16:02:10Z

I'll give it a look. Next Release is something I'm trying out for automating releases notes but I wouldn't worry about it for this release. Although I would like to start labelling all merged PRs going forward to help with this.

TomWFox · 2020-04-13T16:02:47Z

A tag will be created once the release is published through GitHub.

TomWFox

I'd like to switch things up to having changes under the headings 'New Features', 'Improvements' & 'Fixes'. I think it makes the changelog easier to read, especially if there are lots of entries. Sound ok?
(don't worry about the bottom section with CI changes that can stay as is)

noobs2ninjas · 2020-04-13T17:00:33Z

@TomWFox Thanks for editing that. I see how you guys are formatting now. I'll try to do that the first time next release. So, not sure if you got the e-mail yet from Nikita over on bolts but it seems they will be pushing an updated release later today. Once that happens, I'll do a commit updating Carthage versions and our Podspec and then this pull request should be GTG to merge and release.

CHANGELOG.md

…arse-SDK-iOS-OSX into release-1.18.0

TomWFox

I’m happy with the changelog now.

The version in the Parse.podspec file needs to be bumped, not sure if there is any other places.

noobs2ninjas · 2020-04-13T21:05:48Z

@TomWFox Figured I'd wait to bump version and update podspec and carthage for when I can update Bolts to 1.9.1

TomWFox · 2020-04-14T08:27:17Z

Might be worth getting this PR as ready as possible if you want to get this release out quickly.

Also I think we need to take a good look at what what is going on in #1491; the second issue raised about the supported platforms has come up again today in another issue.

drdaz

I've added some quick comments on consistency.

ParseTwitterUtils/ParseTwitterUtils.xcodeproj/project.pbxproj

ParseUI/ParseUI.xcodeproj/project.pbxproj

ParseFacebookUtils/ParseFacebookUtils.xcodeproj/project.pbxproj

Parse/Parse.xcodeproj/project.pbxproj

ParseTwitterUtils/ParseTwitterUtils.xcodeproj/project.pbxproj

ParseUI/ParseUI.xcodeproj/project.pbxproj

noobs2ninjas · 2020-04-16T03:46:43Z

Ok, So for now I'm going to make all iOS targets. Dynamic or not 1,2. I am removing all Catalyst support.
Then before next release let's have a discussion and plan to add Catalyst support and also determine if we even need a "Dynamic" framework anymore.

noobs2ninjas · 2020-04-16T06:05:59Z

Newest release of Bolts is out! Got our podspec and carthage files ready to go. Got @TomWFox fix for iphonesimulator updated. All I need is for these tests to build as expected and we should be ready for 1.18.0 to me merged into master and released!

drdaz

Looks great! 😍

drdaz · 2020-04-16T15:13:27Z

Seems like the failing tests fail more consistently now. That's a very good thing.

Not this release particularly, but compared to last year say. That was one of the problems trying to fix them; I couldn't reliably reproduce the failures.

TomWFox · 2020-04-16T15:23:47Z

Hold off before merging this @drdaz are you ok with #1497?

drdaz · 2020-04-16T15:38:31Z

Hold off before merging this @drdaz are you ok with #1497?

Yup!

And I think you've got a block on the merge 🙂

TomWFox · 2020-04-16T15:53:19Z

Thanks @drdaz. Ahh yes you're right - I thought the branch protection only required one approval but I guess it also requires no outstanding required changes.

TomWFox

Fabby dabby do dar, thanks for the hard work!

TomWFox · 2020-04-16T15:59:06Z

Btw @noobs2ninjas I changed the tag from "Version 1.18.0" to "1.18.0" because it was complaining...

TomWFox · 2020-04-16T16:23:28Z

So not sure what is going on here - when I go to edit the draft release I get a 404 page. @drdaz can you access the page to publish the release?

drdaz · 2020-04-16T17:15:52Z

Yeah I can see it. Weird that you can't ^^

I'll pull the lever yeah?

drdaz · 2020-04-16T17:17:48Z

It looks like it doesn't like the name 'Version 1.18.0'. We should probably stick to something without spaces.

EDIT: I see you already spotted that. I'll try fixing it and releasing.

drdaz · 2020-04-16T17:23:20Z

Ka-ching. 1.18.0 should be out ^^

drdaz · 2020-04-16T17:25:02Z

Hey there was something we had to do to update the version in Cocoapods... anybody remember what? 😬

TomWFox · 2020-04-16T17:31:42Z

Thanks!

@noobs2ninjas bumped the version in the podspec so it should be fine, let's see when the build finishes!

The tagged release build is here btw

TomWFox · 2020-04-16T17:49:45Z

The deploy failed 😭 we might just have to do a manual deploy.

noobs2ninjas · 2020-04-16T18:08:24Z

I can take a look in the morning. Haven’t been able to work on deploy scripts much since we haven’t done a deploy on parse in quite a while

TomWFox · 2020-04-16T21:43:16Z

FWIW here is the explanation of the failure from the build logs...

Resolving dependencies of
-> Parse (1.18.0)
- ERROR | [iOS] unknown: Encountered an unknown error (Unable to find a specification for Bolts/Tasks (~> 1.9.1) depended upon by Parse/Core

You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.

mistyped the name or version.

not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default.

drdaz · 2020-04-16T22:02:18Z

lol frustrating. That was kinda the point of adding the deployment target to our PRs... to make sure this didn't happen.

noobs2ninjas · 2020-04-18T16:49:22Z

I ran pod repo update as part of the script. Still same issue. I know bolts/tasks is available to cocoapods at that version because I just added it to a project and ran pod install and it gets back 1.9.1. However, I did have to run pod repo update first. So, not sure why its not working when I do it on the publish script.

noobs2ninjas · 2020-04-18T16:49:37Z

Going to see if I can lint and validate.

drdaz · 2020-04-18T17:05:17Z

Whatever's gone wrong here, when we figure it out, we should add this to our test suite.

TomWFox · 2020-04-18T17:07:44Z

I'm not sure how you would go about adding it to the test suite fully unless you clone the repo and setup a dummy cocoapod.

drdaz · 2020-04-18T17:08:50Z

Admittedly I wrote that without looking at what's actually going on.

noobs2ninjas · 2020-04-19T03:14:33Z

So you can force a repo update and get version 1.9.1 of bolts/tasks. But then doing a trunk push times out due to no response. If you add verbose then the log gets too full and it kills the task. If you go to the circle CI cocoapods build you can see why. Now there is a new macOS environment that comes out that includes cocoapods 1.9.1 but that’s going to require me to update all the freaking simulators again. Oh forgot to mention the reason this is an issue to begin with is because the 1.7.2 trunk spec is finalized and now it will be dynamically making them. God this drives me nuts. Wish we could just switch to circle completely.

…

On Sat, Apr 18, 2020 at 12:09 PM Darren Black ***@***.***> wrote: Admittedly I wrote that without looking at what's actually going on. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1494 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2BOX53QVHZX7T35VU36TTRNHNC5ANCNFSM4MHBGDDQ> .

noobs2ninjas added 2 commits April 13, 2020 10:03

Updating all Swift versions to say 5.0. Updating all Builds to say 1.…

7be35ce

…18.0.

Finishing Changelog.

2274d3e

noobs2ninjas added the 1.18.0 label Apr 13, 2020

noobs2ninjas linked an issue Apr 13, 2020 that may be closed by this pull request

Putting together Parse 1.18.0 release. #1482

Closed

TomWFox suggested changes Apr 13, 2020

View reviewed changes

TomWFox added 2 commits April 13, 2020 17:08

remove unnecessary brackets

1ac845e

fix master full changelog diff

4ac7b14

TomWFox added Release and removed 1.18.0 labels Apr 13, 2020

add links, constant formatting

7caffc5

add new headings

bfc10a7

TomWFox reviewed Apr 13, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Adding missing pull request links to improvements.

a89cd15

noobs2ninjas linked an issue Apr 13, 2020 that may be closed by this pull request

Cocoapod Dependency Issue #1484

Closed

TomWFox reviewed Apr 13, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

TomWFox and others added 4 commits April 13, 2020 19:51

fix formatting

99721c1

Adding missing pull request links.

94bfb1d

Merge branch 'release-1.18.0' of https://github.com/parse-community/P…

c90fb1a

…arse-SDK-iOS-OSX into release-1.18.0

Fix formatting

16d1152

TomWFox requested a review from drdaz April 13, 2020 20:17

TomWFox suggested changes Apr 13, 2020

View reviewed changes

drdaz reviewed Apr 14, 2020

View reviewed changes

noobs2ninjas requested a review from TomWFox April 16, 2020 06:04

noobs2ninjas requested a review from drdaz April 16, 2020 06:10

noobs2ninjas linked an issue Apr 16, 2020 that may be closed by this pull request

Xcode 11.4, App Store Upload Error - Minimum OS Version #1491

Closed

add entry to changelog

1d23095

drdaz approved these changes Apr 16, 2020

View reviewed changes

TomWFox approved these changes Apr 16, 2020

View reviewed changes

TomWFox merged commit 09815dc into master Apr 16, 2020

TomWFox deleted the release-1.18.0 branch April 16, 2020 16:15

Release 1.18.0 #1494

Release 1.18.0 #1494

Conversation

noobs2ninjas commented Apr 13, 2020

noobs2ninjas commented Apr 13, 2020

noobs2ninjas commented Apr 13, 2020

TomWFox commented Apr 13, 2020

TomWFox commented Apr 13, 2020

TomWFox left a comment

Choose a reason for hiding this comment

noobs2ninjas commented Apr 13, 2020

TomWFox left a comment

Choose a reason for hiding this comment

noobs2ninjas commented Apr 13, 2020

TomWFox commented Apr 14, 2020

drdaz left a comment

Choose a reason for hiding this comment

noobs2ninjas commented Apr 16, 2020

noobs2ninjas commented Apr 16, 2020

drdaz left a comment

Choose a reason for hiding this comment

drdaz commented Apr 16, 2020 • edited Loading

TomWFox commented Apr 16, 2020

drdaz commented Apr 16, 2020

TomWFox commented Apr 16, 2020

TomWFox left a comment

Choose a reason for hiding this comment

TomWFox commented Apr 16, 2020 • edited Loading

TomWFox commented Apr 16, 2020

drdaz commented Apr 16, 2020

drdaz commented Apr 16, 2020 • edited Loading

drdaz commented Apr 16, 2020

drdaz commented Apr 16, 2020

TomWFox commented Apr 16, 2020 • edited Loading

TomWFox commented Apr 16, 2020

noobs2ninjas commented Apr 16, 2020 • edited Loading

TomWFox commented Apr 16, 2020

drdaz commented Apr 16, 2020

noobs2ninjas commented Apr 18, 2020

noobs2ninjas commented Apr 18, 2020

drdaz commented Apr 18, 2020

TomWFox commented Apr 18, 2020

drdaz commented Apr 18, 2020

noobs2ninjas commented Apr 19, 2020 via email

drdaz commented Apr 16, 2020 •

edited

Loading

TomWFox commented Apr 16, 2020 •

edited

Loading

drdaz commented Apr 16, 2020 •

edited

Loading

TomWFox commented Apr 16, 2020 •

edited

Loading

noobs2ninjas commented Apr 16, 2020 •

edited

Loading