Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade to Facebook SDK 13 via SPM #1636

Closed
wants to merge 5 commits into from
Closed

feat: Upgrade to Facebook SDK 13 via SPM #1636

wants to merge 5 commits into from

Conversation

drdaz
Copy link
Member

@drdaz drdaz commented Mar 10, 2022 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

Facebook SDK compatibility. Moves to SPM for internal dependency management.

Closes #1635

Approach

Removed most of the mishmash of other approaches to internal dependency management, and replaced it with SPM.
Updated FB lib version to 13.

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 10, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

@drdaz drdaz changed the title enhancement - FB lib update, SPM dependencies enhancement: FB lib update, SPM dependencies Mar 10, 2022
@drdaz drdaz changed the title enhancement: FB lib update, SPM dependencies build: FB lib update, SPM dependencies Mar 10, 2022
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title build: FB lib update, SPM dependencies build: fB lib update, SPM dependencies Mar 10, 2022
@mtrezza mtrezza mentioned this pull request Nov 4, 2022
Closed
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title build: fB lib update, SPM dependencies build: FB lib update, SPM dependencies Nov 4, 2022
@mtrezza mtrezza changed the title build: FB lib update, SPM dependencies feat: Upgrade to Facebook SDK 13 via SPM Nov 4, 2022
@mtrezza
Copy link
Member

mtrezza commented Nov 4, 2022 •
edited
Loading

Pretty nice that this also moves to SPM; do you think you could bring this up-to-date so we can merge it? Or is there any obstacle left in this PR?

@mtrezza
Copy link
Member

mtrezza commented Jan 30, 2023

Closing in favor of #1683

@mtrezza mtrezza closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Facebook SDK to latest version
2 participants
@drdaz @mtrezza