Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Compilation error on macOS Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler #1739

Merged
merged 1 commit into from
Sep 30, 2023
Merged

fix: Compilation error on macOS Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler #1739

merged 1 commit into from
Sep 30, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 28, 2023 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

PFProduct and PFPurchase aren't supported on MacOS

Closes: #1699

Approach

  • Remove PFPurchaseController from Mac build

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 28, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dplewis dplewis mentioned this pull request Sep 28, 2023
Closed
4 tasks
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2316a3f) 77.86% compared to head (1975c55) 78.22%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
+ Coverage   77.86%   78.22%   +0.35%     
==========================================
  Files         299      307       +8     
  Lines       36328    36981     +653     
==========================================
+ Hits        28288    28927     +639     
- Misses       8040     8054      +14
Files Coverage Δ
...nternal/Purchase/Controller/PFPurchaseController.m 88.81% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis
fix: Mac build Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler
1975c55 
install swift 5.5

Revert "fix: Mac build Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler"

This reverts commit d8723d2.

Revert "install swift 5.5"

This reverts commit 23454f9.

Update PFPurchaseController.m
@dplewis dplewis requested a review from mtrezza September 28, 2023 04:45
@mtrezza mtrezza changed the title fix: Mac build Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler fix: Compilation error on macOS Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler Sep 28, 2023
@mtrezza
Copy link
Member

mtrezza commented Sep 28, 2023 •
edited
Loading

I've changed the PR title, could you check whether it's correct? As a reminder, the PR title will be part of the changelog and should describe what the bug is, rather than what the solution or fixed state is.

@dplewis
Copy link
Member Author

dplewis commented Sep 28, 2023

That is correct

mtrezza
mtrezza approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza merged commit 7231bf7 into parse-community:master Sep 30, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 30, 2023
@semantic-release-bot
chore(release): 2.7.1 [skip ci]
c420b82 
## [2.7.1](2.7.0...2.7.1) (2023-09-30)

### Bug Fixes

* Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` ([#1739](#1739)) ([7231bf7](7231bf7))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.7.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 30, 2023
@dplewis dplewis deleted the fix-pfproduct branch October 3, 2023 20:46
eeallen1 added a commit to eeallen1/Parse-SDK-iOS-OSX that referenced this pull request May 6, 2024
@eeallen1
Merge commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02'
53e8034 
* commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02': (86 commits)
  chore(release): 3.0.0 [skip ci]
  ci: Fix release workflow (parse-community#1782)
  feat: Remove `ParseFacebookUtils` and `ParseTwitterUtils` (parse-community#1779)
  feat: Add `PFObject.isDataAvailableForKey` to check if data is available for individual key (parse-community#1756)
  ci: Bump ip from 2.0.0 to 2.0.1 (parse-community#1772)
  ci: Fix failing CI by pinning bundler version (parse-community#1778)
  refactor: Remove Carthage dependency (parse-community#1763)
  refactor: Remove OCMock Carthage dependency (parse-community#1754)
  ci: Run CI on Xcode 15 and macOS 13 (parse-community#1753)
  refactor: Update ruby dependencies (parse-community#1752)
  refactor: Remove framework builder for assets (parse-community#1751)
  chore(release): 2.7.3 [skip ci]
  fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 (parse-community#1749)
  docs: Add changelog note about missing assets (parse-community#1750)
  chore(release): 2.7.2 [skip ci]
  fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS (parse-community#1748)
  ci: Remove publishing release assets (parse-community#1745)
  ci: Fix and build Starter Projects (parse-community#1744)
  chore(release): 2.7.1 [skip ci]
  fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` (parse-community#1739)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in macOS project _OBJC_CLASS_$_PFProductsRequestHandler version 2.0.2
3 participants
@dplewis @mtrezza @parseplatformorg