Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Carthage dependency #1763

Merged
merged 1 commit into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,6 @@ jobs:
- name: Bundle Install
if: steps.cache-gems.outputs.cache-hit != 'true'
run: bundle install
- name: Cache Carthage
uses: actions/cache@v3
id: carthage-cache
with:
path: Carthage
key: ${{ runner.os }}-carthage-${{ hashFiles('**/Cartfile.resolved') }}
restore-keys: |
${{ runner.os }}-carthage-
- name: Carthage
if: ${{ steps.carthage-cache.outputs.cache-hit != 'true' }}
run: |
carthage bootstrap --use-xcframeworks
- name: Build-Test
run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake ${{ matrix.script == 'xcode15' && 'build:starters' || matrix.script }}
env:
Expand Down
6 changes: 0 additions & 6 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
[submodule "Vendor/xctoolchain"]
path = Vendor/xctoolchain
url = https://github.com/parse-community/xctoolchain.git
[submodule "Carthage/Checkouts/Bolts-ObjC"]
path = Carthage/Checkouts/Bolts-ObjC
url = https://github.com/BoltsFramework/Bolts-ObjC.git
[submodule "Carthage/Checkouts/facebook-ios-sdk"]
path = Carthage/Checkouts/facebook-ios-sdk
url = https://github.com/facebook/facebook-ios-sdk.git
2 changes: 0 additions & 2 deletions Cartfile

This file was deleted.

2 changes: 0 additions & 2 deletions Cartfile.resolved

This file was deleted.

1 change: 0 additions & 1 deletion Carthage/Checkouts/Bolts-ObjC
Submodule Bolts-ObjC deleted from 74b67b
1 change: 0 additions & 1 deletion Carthage/Checkouts/facebook-ios-sdk
Submodule facebook-ios-sdk deleted from 7fd8a9
378 changes: 74 additions & 304 deletions Parse/Parse.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

6 changes: 1 addition & 5 deletions Parse/Parse/Source/PFAnalytics.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@

#import <Foundation/Foundation.h>

#if __has_include(<Bolts/BFTask.h>)
#import <Bolts/BFTask.h>
#else
#import "BFTask.h"
#endif
@import Bolts;

#import "PFConstants.h"

Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Other/OCMock/OCMock+Parse.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import "OCMock+Parse.h"

@import Bolts.BFTask;
@import Bolts;

#import "PFCommandResult.h"
#import "PFCommandRunning.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Other/Swift/SwiftSubclass.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import Foundation

import Parse
import ParseCore

@objc
public class SwiftSubclass: PFObject, PFSubclassing {
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Other/TestCases/TestCase/PFTestCase.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import "PFTestCase.h"

@import Bolts.BFTask;
@import Bolts;

#import "PFTestSwizzlingUtilities.h"

Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/AnalyticsUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFAnalyticsController.h"
#import "PFUnitTestCase.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/AnonymousAuthenticationProviderTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

@import Bolts.BFTask;
@import Bolts;

#import "PFAnonymousAuthenticationProvider.h"
#import "PFTestCase.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/CloudCodeControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "OCMock+Parse.h"
#import "PFCloudCodeController.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/ConfigControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "OCMock+Parse.h"
#import "PFCommandResult.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/ConfigUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFConfigController.h"
#import "PFConfig_Private.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/CurrentConfigControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "BFTask+Private.h"
#import "PFCommandResult.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/DefaultACLControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFACLPrivate.h"
#import "PFCoreManager.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/ExtensionDataSharingTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

@import Bolts.BFTask;
@import Bolts;

#import "PFExtensionDataSharingTestHelper.h"
#import "PFFileManager.h"
Expand Down
4 changes: 1 addition & 3 deletions Parse/Tests/Unit/FileControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFCancellationTokenSource;
@import Bolts.BFTask;
@import Bolts.BFTaskCompletionSource;
@import Bolts;

#import "PFCommandResult.h"
#import "PFCommandRunning.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/FileUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFCoreManager.h"
#import "PFFileController.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/ObjectFilePersistenceControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

@import Bolts.BFTask;
@import Bolts;

#import "BFTask+Private.h"
#import "PFObject.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/ObjectOfflineTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

@import Bolts.BFTask;
@import Bolts;

#import "PFObject.h"
#import "PFOfflineStore.h"
Expand Down
3 changes: 1 addition & 2 deletions Parse/Tests/Unit/OfflineQueryControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFCancellationTokenSource;
@import Bolts.BFTask;
@import Bolts;

#import "OCMock+Parse.h"
#import "PFCommandResult.h"
Expand Down
3 changes: 1 addition & 2 deletions Parse/Tests/Unit/PurchaseControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFExecutor;
@import Bolts.BFTask;
@import Bolts;

#import "PFCommandResult.h"
#import "PFCommandRunning.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/PurchaseUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFCommandRunning.h"
#import "PFFileManager.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/PushChannelsControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFCurrentInstallationController.h"
#import "PFInstallation.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/PushControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFCommandResult.h"
#import "PFCommandRunning.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/PushUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.H>

@import Bolts.BFTask;
@import Bolts;

#import "PFCoreManager.h"
#import "PFCurrentInstallationController.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/QueryCachedControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFCachedQueryController.h"
#import "PFCommandResult.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/QueryControllerUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFCancellationTokenSource;
@import Bolts;

#import "BFTask+Private.h"
#import "PFCommandResult.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/QueryUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFTask;
@import Bolts;

#import "PFCoreManager.h"
#import "PFMacros.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/RoleUnitTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

@import Bolts.BFTask;
@import Bolts;

#import "PFMockURLProtocol.h"
#import "PFRelation.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/SQLiteDatabaseTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

@import Bolts.BFTask;
@import Bolts;

#import "BFTask+Private.h"
#import "PFFileManager.h"
Expand Down
3 changes: 1 addition & 2 deletions Parse/Tests/Unit/URLSessionCommandRunnerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFCancellationTokenSource;
@import Bolts.BFTask;
@import Bolts;

#import "PFCommandResult.h"
#import "PFCommandRunningConstants.h"
Expand Down
3 changes: 1 addition & 2 deletions Parse/Tests/Unit/URLSessionDataTaskDelegateTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFCancellationTokenSource;
@import Bolts.BFTask;
@import Bolts;

#import "PFCommandResult.h"
#import "PFConstants.h"
Expand Down
3 changes: 1 addition & 2 deletions Parse/Tests/Unit/URLSessionTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFCancellationTokenSource;
@import Bolts.BFTask;
@import Bolts;

#import "PFCommandResult.h"
#import "PFMacros.h"
Expand Down
3 changes: 1 addition & 2 deletions Parse/Tests/Unit/URLSessionUploadTaskDelegateTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

#import <OCMock/OCMock.h>

@import Bolts.BFCancellationTokenSource;
@import Bolts.BFTask;
@import Bolts;

#import "PFCommandResult.h"
#import "PFTestCase.h"
Expand Down
2 changes: 1 addition & 1 deletion Parse/Tests/Unit/UserControllerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/

@import Bolts.BFTask;
@import Bolts;

#import "OCMock+Parse.h"
#import "PFCommandResult.h"
Expand Down
Loading
Loading