Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support for PFFiles. #197

Merged
merged 1 commit into from
Sep 10, 2015
Merged

Add https support for PFFiles. #197

merged 1 commit into from
Sep 10, 2015

Conversation

nlutsenko
Copy link
Contributor

This is still pending backend changes to actually enable https, but just throwing this in, since this is the only client-side change required.
Fixes #12

}

if (!self.urlString) {
return self.urlString;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to return nil for readability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nlutsenko nlutsenko force-pushed the nlutsenko.httpsfiles branch from 2cb4207 to d6ee925 Compare September 9, 2015 17:39
@nlutsenko nlutsenko added this to the 1.8.3 milestone Sep 9, 2015
nlutsenko added a commit that referenced this pull request Sep 10, 2015
@nlutsenko nlutsenko merged commit 80f27c2 into master Sep 10, 2015
@nlutsenko nlutsenko deleted the nlutsenko.httpsfiles branch September 10, 2015 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants