Fix initialization of Facebook/Twitter Utils blocking the main thread. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (![authType isEqualToString:PFAnonymousUserAuthenticationType]) { | ||
| [[PFUser currentUser] synchronizeAuthDataWithAuthType:authType]; | ||
| } | ||
| [[[PFUser currentUserController] getCurrentUserAsyncWithOptions:0] continueWithSuccessBlock:^id(BFTask *task) { |
There was a problem hiding this comment.
How hard is it to have this injected? I don't really like having this be harder than necessary to test.
There was a problem hiding this comment.
Sure, let's do it. It's going to be much better.
nlutsenko
force-pushed
the
nlutsenko.auth
branch
from
910407b to
e5aaf90
Compare
|
Injecting the currentUserController, all the way! |
nlutsenko
added a commit
that referenced
this pull request
Sep 23, 2015
Fix initialization of Facebook/Twitter Utils blocking the main thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make load of currentUser asynchronous, as well as won't create anonymous user if enabled, and will properly restore auth from a background thread.
Fixes #302