Made all accesses to PFSQLiteDatabaseResult & Statement thread-safe. #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #import "PFThreadsafety.h" | ||
|
|
||
| // PFThreadsafetySafeDispatchSync, but with a return type. | ||
| #define thread_safe_sync(queue, block) ({ \ |
There was a problem hiding this comment.
Any chance we can make this a function?
This is not going to be nice (probably), but might feel better than having 2 defines that do the same thing...
There was a problem hiding this comment.
I'm not sure how we can, seeing as the point of this macro is to be able to easily return any type, not just id or int.
We could stick it in PFThreadsafety.h, perhaps?
There was a problem hiding this comment.
Sounds good, let's do it! :)
|
Few nits, otherwise lgtm. |
richardjrossiii
force-pushed
the
richardross.localdatastore.sqlite.threadsafe
branch
from
484a572 to
66f9bca
Compare
|
PR updated. |
|
Awesome! Please ship! |
I think this is what was causing the crashes seen in #290, but I'm not 100% sure. At the very least, accessing them this way was in violation of the SQLite spec.
richardjrossiii
force-pushed
the
richardross.localdatastore.sqlite.threadsafe
branch
from
66f9bca to
9757503
Compare
richardjrossiii
added a commit
that referenced
this pull request
Nov 10, 2015
….sqlite.threadsafe Made all accesses to PFSQLiteDatabaseResult & Statement thread-safe.
richardjrossiii
deleted the
richardross.localdatastore.sqlite.threadsafe
branch
|
Awesome! It's HUUUUUUUUGE! |
|
@coolnalu No problem <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is what was causing the crashes seen in #290, but I'm not 100% sure.
At the very least, accessing them this way was in violation of the SQLite spec.