-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: Correctly save objectId of Installation #116
Conversation
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 80.95% 80.66% -0.30%
==========================================
Files 65 65
Lines 5461 5498 +37
==========================================
+ Hits 4421 4435 +14
- Misses 1040 1063 +23
Continue to review full report at Codecov.
|
…d config to keychain
ParseInstallation
is slightly different than otherParseObjects
as it's created with a unique identifier (installationId
) locally on the device and may or may not be saved depending on the app use case. This fixes a bug for when the Installation is saved to the server and the objectId of the Installation wasn't saved to the Keychain. This prevents the ability to fetch an updated Installation because fetch is based on theobjectId
.Fix #115 Should also fix multiple save issue mentioned in #93