Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded to Swift 5 #12

Merged
merged 61 commits into from
Jul 14, 2020
Merged

Upgraded to Swift 5 #12

merged 61 commits into from
Jul 14, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jul 9, 2020 •
edited
Loading

This PR builds off of ShawnBaeks PR #9 as many of fixes seemed to be approved by Flo.

In addition to upgrading, I made changes to the force unwrap test cases as they should fail gracefully and allow the rest of the tests to run even if one fails.

ShawnBaek and others added 30 commits December 30, 2018 21:45
@ShawnBaek
Fix Swift Lint Errors
e0e4130
@ShawnBaek
Set Travis target to xcode10
12e1ac7
@ShawnBaek
Rollback podspec
a723b27
@ShawnBaek
Add @discardableResult
710d707
@ShawnBaek
Fix Test Cases
600fa81
@ShawnBaek
Acted on Reviers comment
d774249
@ShawnBaek
Add subscript function for [Any] to fix ParseSwiftTests cases
e527903
@ShawnBaek
Update Podspec
05a86e7
@ShawnBaek
Revert for @discardableResult
378248c 
Changed e -> error
@ShawnBaek
Acted on @mooshee feedback
7399d37
@ShawnBaek
remove discardableResult for removeAllObjects
f866536
@ShawnBaek
Update Pod Script : pod lib lint --verbose --no-clean
15c1d9a
@ShawnBaek
Revert KeychainStore.swift
e6aeec0
@ShawnBaek
Revert travis.yml
f487baf
@flovilmart
Adds more verbose logs for pod lib lint
868ec78
@ShawnBaek
Add Codable Structure to set and get complexObject.
f2e18e3 
comment the testComplexObject.
@ShawnBaek
Merge branch 'upstream-master' of github.com:ShawnBaek/Parse-Swift in…
dca1bc2 
…to upstream-master
@ShawnBaek
declare ComplexObject Struct in Class
fed6eb7
@ShawnBaek
set IPHONE_DEPLOYMENT_TARGET = 10.0
e776abb
@ShawnBaek
Add test spec in PodSpec
fe0d859
@flovilmart
Revert podspec, print cocoapods version
47c0932
@flovilmart
Use cocoapods > 1.6.0 in order to workaround lint issue
3b81390 
bpoplauschi/SDWebImage@af14895
CocoaPods/CocoaPods#7720
@flovilmart
Revert "set IPHONE_DEPLOYMENT_TARGET = 10.0"
3ba6ee4 
This reverts commit e776abb.
@flovilmart
lower pod iOS deployment target
9eb914e
@ShawnBaek
Revert
5927703
@ShawnBaek
Merge branch 'upstream-master' of github.com:ShawnBaek/Parse-Swift in…
5899b5a 
…to upstream-master
@ShawnBaek
revert testSetComplexObject
1eee004
@ShawnBaek
Add AnyCodable
5310345
@ShawnBaek
Apply AnyCodable
18aae3e
@cbaker6
Upgraded and fixed warnings
34dca0a
@cbaker6 cbaker6 marked this pull request as draft July 11, 2020 01:23
@cbaker6 cbaker6 marked this pull request as ready for review July 11, 2020 01:44
@ShawnBaek
Copy link
Contributor

@cbaker6 Thanks a lot!!!

ShawnBaek
ShawnBaek previously approved these changes Jul 11, 2020
View reviewed changes
@cbaker6 cbaker6 mentioned this pull request Jul 12, 2020
Closed
pranjalsatija
pranjalsatija previously approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@pranjalsatija pranjalsatija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

TomWFox
TomWFox previously approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this project going again 👍

Just a very minor comment formatting change.

Sources/ParseSwift/AnyCodable/AnyCodable.swift Outdated Show resolved Hide resolved
@cbaker6 @TomWFox
Update Sources/ParseSwift/AnyCodable/AnyCodable.swift
eb62ff2 
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@cbaker6 cbaker6 dismissed stale reviews from TomWFox, pranjalsatija, and ShawnBaek via eb62ff2 July 14, 2020 17:56
@cbaker6
Copy link
Contributor Author

cbaker6 commented Jul 14, 2020

@TomWFox np, I’m not sure what happened here, I accepted your changes, but it dismissed all of the reviews which wasn’t my intention

@TomWFox
Copy link
Contributor

TomWFox commented Jul 14, 2020

Nothing to do with you, it's because of some branch protections I just added. I think I'll remove that particular one as it's a bit annoying!

@TomWFox TomWFox merged commit 86bdeb0 into parse-community:master Jul 14, 2020
@cbaker6 cbaker6 mentioned this pull request Jul 14, 2020
Closed
@cbaker6 cbaker6 deleted the upgrades branch July 14, 2020 18:54
This was referenced Jul 15, 2020
Closed
Merged
@cbaker6 cbaker6 mentioned this pull request Sep 18, 2020
Closed
@alessdiimperio alessdiimperio mentioned this pull request Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWFox TomWFox TomWFox left review comments

@ShawnBaek ShawnBaek ShawnBaek left review comments

@pranjalsatija pranjalsatija pranjalsatija left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cbaker6 @TomWFox @drdaz @ShawnBaek @pranjalsatija @flovilmart